From: Ricardo Ribalda <ribalda@chromium.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Jonathan Corbet <corbet@lwn.net>
Cc: Ricardo Ribalda <ribalda@chromium.org>,
linux-doc@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 1/2] earlycon: Replace simple_strtoul with kstrtouint
Date: Thu, 24 Nov 2022 11:02:18 +0100 [thread overview]
Message-ID: <20221123-serial-clk-v2-1-9c03ce8940d8@chromium.org> (raw)
In-Reply-To: <20221123-serial-clk-v2-0-9c03ce8940d8@chromium.org>
Baud rate is declared as unsigned integer. Use the right function.
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
diff --git a/drivers/tty/serial/earlycon.c b/drivers/tty/serial/earlycon.c
index a5f380584cda..5b73da9487b1 100644
--- a/drivers/tty/serial/earlycon.c
+++ b/drivers/tty/serial/earlycon.c
@@ -120,7 +120,9 @@ static int __init parse_options(struct earlycon_device *device, char *options)
}
if (options) {
- device->baud = simple_strtoul(options, NULL, 0);
+ if (kstrtouint(options, 0, &device->baud) < 0)
+ pr_warn("[%s] unsupported earlycon baud rate option\n",
+ options);
length = min(strcspn(options, " ") + 1,
(size_t)(sizeof(device->options)));
strscpy(device->options, options, length);
@@ -303,7 +305,9 @@ int __init of_setup_earlycon(const struct earlycon_id *match,
port->uartclk = be32_to_cpu(*val);
if (options) {
- early_console_dev.baud = simple_strtoul(options, NULL, 0);
+ if (kstrtouint(options, 0, &early_console_dev.baud) < 0)
+ pr_warn("[%s] unsupported earlycon baud rate options\n",
+ options);
strscpy(early_console_dev.options, options,
sizeof(early_console_dev.options));
}
--
b4 0.11.0-dev-d93f8
next prev parent reply other threads:[~2022-11-24 10:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-24 10:02 [PATCH v2 0/2] earlycon: Let users set the clock frequency Ricardo Ribalda
2022-11-24 10:02 ` Ricardo Ribalda [this message]
2022-11-24 10:02 ` [PATCH v2 2/2] " Ricardo Ribalda
2022-11-24 11:19 ` Jiri Slaby
2022-11-24 12:10 ` Ricardo Ribalda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221123-serial-clk-v2-1-9c03ce8940d8@chromium.org \
--to=ribalda@chromium.org \
--cc=corbet@lwn.net \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).