From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0BC9CC6FD1D for ; Thu, 30 Mar 2023 08:38:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229968AbjC3Iih (ORCPT ); Thu, 30 Mar 2023 04:38:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230005AbjC3Ii0 (ORCPT ); Thu, 30 Mar 2023 04:38:26 -0400 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3674472AB; Thu, 30 Mar 2023 01:38:23 -0700 (PDT) Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4PnGx448Glz6J7dB; Thu, 30 Mar 2023 16:36:40 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 30 Mar 2023 09:38:20 +0100 Date: Thu, 30 Mar 2023 09:38:20 +0100 From: Jonathan Cameron To: Rob Herring CC: "Rafael J. Wysocki" , Len Brown , Marcelo Schmitt , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Greg Kroah-Hartman , Johannes Berg , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jiri Slaby , Thierry Reding , Jonathan Hunter , "Marc Zyngier" , , , , , , , , , Subject: Re: [PATCH 2/5] staging: iio: resolver: ad2s1210: Add explicit include for of.h Message-ID: <20230330093820.0000639d@Huawei.com> In-Reply-To: <20230329-acpi-header-cleanup-v1-2-8dc5cd3c610e@kernel.org> References: <20230329-acpi-header-cleanup-v1-0-8dc5cd3c610e@kernel.org> <20230329-acpi-header-cleanup-v1-2-8dc5cd3c610e@kernel.org> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500001.china.huawei.com (7.191.163.213) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Wed, 29 Mar 2023 16:20:43 -0500 Rob Herring wrote: > With linux/acpi.h no longer implicitly including of.h, add an explicit > include of of.h to fix the following error: > > drivers/staging/iio/resolver/ad2s1210.c:706:21: error: implicit declaration of function 'of_match_ptr' is invalid in C99 [-Werror,-Wimplicit-function-declaration] > > Signed-off-by: Rob Herring Acked-by: Jonathan Cameron > --- > drivers/staging/iio/resolver/ad2s1210.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c > index e4cf42438487..eb364639fa58 100644 > --- a/drivers/staging/iio/resolver/ad2s1210.c > +++ b/drivers/staging/iio/resolver/ad2s1210.c > @@ -7,6 +7,7 @@ > #include > #include > #include > +#include > #include > #include > #include >