From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0FE99C77B70 for ; Thu, 30 Mar 2023 12:59:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231703AbjC3M7g (ORCPT ); Thu, 30 Mar 2023 08:59:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53916 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231367AbjC3M7e (ORCPT ); Thu, 30 Mar 2023 08:59:34 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id AE43F974B; Thu, 30 Mar 2023 05:59:33 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id F407F80FE; Thu, 30 Mar 2023 12:59:32 +0000 (UTC) Date: Thu, 30 Mar 2023 15:59:31 +0300 From: Tony Lindgren To: Greg Kroah-Hartman Cc: Jiri Slaby , Andy Shevchenko , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-omap@vger.kernel.org, Andy Shevchenko , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v9 1/1] serial: core: Start managing serial controllers to enable runtime PM Message-ID: <20230330125931.GT7501@atomide.com> References: <20230323071051.2184-1-tony@atomide.com> <20230330113231.GR7501@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org * Greg Kroah-Hartman [230330 12:52]: > On Thu, Mar 30, 2023 at 02:32:31PM +0300, Tony Lindgren wrote: > > * Greg Kroah-Hartman [230329 09:08]: > > > On Thu, Mar 23, 2023 at 09:10:47AM +0200, Tony Lindgren wrote: > > > > --- /dev/null > > > > +++ b/drivers/tty/serial/serial_base.c > > > > @@ -0,0 +1,142 @@ > > > > +// SPDX-License-Identifier: GPL-2.0-or-later > > > > > > Given that the driver core is "GPL-2.0-only", why is this -or-later? > > > > Thanks for noticing, the intention was to set it to what serial_core.c has: > > > > $ git grep -e SPDX -e MODULE_LICENSE drivers/tty/serial/serial_core.c > > drivers/tty/serial/serial_core.c:// SPDX-License-Identifier: GPL-2.0+ > > drivers/tty/serial/serial_core.c:MODULE_LICENSE("GPL"); > > Doesn't mean you have to copy it, it's your choice :) In this case my preference is to use the same as for serial_core.c. This is so folks can start moving serial port specific functions from serial_core.c to serial_port.c. And not have to worry about the possible differences with various licenses at that point :) Tony