Re: [PATCH] tty: serial: sh-sci: Fix transmit end interrupt handler

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Tue, Apr 11, 2023 at 02:40:52PM +0000, Biju Das wrote:
> Hi Greg,
> 
> > Subject: RE: [PATCH] tty: serial: sh-sci: Fix transmit end interrupt handler
> > 
> > Hi Greg,
> > 
> > Thanks for the feedback.
> > 
> > > Subject: Re: [PATCH] tty: serial: sh-sci: Fix transmit end interrupt
> > > handler
> > >
> > > On Tue, Apr 11, 2023 at 11:08:59AM +0100, Biju Das wrote:
> > > > commit b43a18647f03c87e77d50d6fe74904b61b96323e upstream.
> > > >
> > > > The fourth interrupt on SCI port is transmit end interrupt compared
> > > > to the break interrupt on other port types. So, shuffle the
> > > > interrupts to fix the transmit end interrupt handler.
> > > >
> > > > Fixes: e1d0be616186 ("sh-sci: Add h8300 SCI")
> > > > Cc: stable <stable@kernel.org>
> > > > Suggested-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > > Link:
> > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > > > [biju: manually fixed the conflicts]
> > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > > ---
> > > > Resending to 4.14 with confilcts [1] fixed.
> > > > [1]
> > >
> > > You did not actually build your patch, as it breaks the build :(
> > 
> > Actually, I build the patch, but did not test it on target as I don't have
> > the platform to test it.
> > 
> > I got some issues while building modules which is unrelated to this change.
> > 
> > Anyway, I will double check again and confirm.
> 
> I confirm, there is an issue with this patch.
> 
> I disabled building modules from my build script and it showed the below error. 
> So I would like to drop this patch for 4.14 as this header file does not exist for 4.14.
> 
> drivers/tty/serial/sh-sci.c:40:10: fatal error: linux/minmax.h: No such file or directory
>    40 | #include <linux/minmax.h>
>       |          ^~~~~~~~~~~~~~~~

Yes, minmax is not there, but the function needed by that is there
(hint, I had to remove that include in 4.19).  Remove it and see the
next error you get :)

thanks,

greg k-h