From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB886C77B6F for ; Wed, 12 Apr 2023 06:38:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229762AbjDLGhn (ORCPT ); Wed, 12 Apr 2023 02:37:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51108 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbjDLGhm (ORCPT ); Wed, 12 Apr 2023 02:37:42 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A147D5BBD; Tue, 11 Apr 2023 23:37:33 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E4C6C62E84; Wed, 12 Apr 2023 06:37:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EA6BDC433EF; Wed, 12 Apr 2023 06:37:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1681281452; bh=C08xlScrwcFLdBM4M2cjiejNGUOC2cBgygJXW4F0akQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OvPmm65tFUtKMb6uvKdWdj+CwHnU3HWMLPT3Jz6E92n9YwogMdR4ulZuq7okqBdT7 Ffzjig8MFiNLWWQIW/VHk4EEiH38RDfTTckhEH97Sknhaf8qxgdKfAgBJ1vkBkVssg a3tVu+XhCbytOYlwY1MasJtSi0KC2KPJkv2UM58I= Date: Wed, 12 Apr 2023 08:37:29 +0200 From: Greg Kroah-Hartman To: Biju Das Cc: Jiri Slaby , "linux-serial@vger.kernel.org" , Geert Uytterhoeven , Niklas =?iso-8859-1?Q?S=F6derlund?= , Prabhakar Mahadev Lad , "linux-renesas-soc@vger.kernel.org" , stable Subject: Re: [PATCH] tty: serial: sh-sci: Fix transmit end interrupt handler Message-ID: <2023041214-epidural-overrate-3b81@gregkh> References: <20230411100859.305617-1-biju.das.jz@bp.renesas.com> <2023041129-skeleton-nursery-f9b0@gregkh> <2023041158-crisped-obtrusive-2309@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Tue, Apr 11, 2023 at 03:36:04PM +0000, Biju Das wrote: > > Hi Greg, > > > Subject: Re: [PATCH] tty: serial: sh-sci: Fix transmit end interrupt handler > > > > On Tue, Apr 11, 2023 at 02:40:52PM +0000, Biju Das wrote: > > > Hi Greg, > > > > > > > Subject: RE: [PATCH] tty: serial: sh-sci: Fix transmit end interrupt > > > > handler > > > > > > > > Hi Greg, > > > > > > > > Thanks for the feedback. > > > > > > > > > Subject: Re: [PATCH] tty: serial: sh-sci: Fix transmit end > > > > > interrupt handler > > > > > > > > > > On Tue, Apr 11, 2023 at 11:08:59AM +0100, Biju Das wrote: > > > > > > commit b43a18647f03c87e77d50d6fe74904b61b96323e upstream. > > > > > > > > > > > > The fourth interrupt on SCI port is transmit end interrupt > > > > > > compared to the break interrupt on other port types. So, shuffle > > > > > > the interrupts to fix the transmit end interrupt handler. > > > > > > > > > > > > Fixes: e1d0be616186 ("sh-sci: Add h8300 SCI") > > > > > > Cc: stable > > > > > > Suggested-by: Geert Uytterhoeven > > > > > > Signed-off-by: Biju Das > > > > > > Link: > > > > > > Signed-off-by: Greg Kroah-Hartman > > > > > > [biju: manually fixed the conflicts] > > > > > > Signed-off-by: Biju Das > > > > > > --- > > > > > > Resending to 4.14 with confilcts [1] fixed. > > > > > > [1] > > > > > > > > > > You did not actually build your patch, as it breaks the build :( > > > > > > > > Actually, I build the patch, but did not test it on target as I > > > > don't have the platform to test it. > > > > > > > > I got some issues while building modules which is unrelated to this > > change. > > > > > > > > Anyway, I will double check again and confirm. > > > > > > I confirm, there is an issue with this patch. > > > > > > I disabled building modules from my build script and it showed the below > > error. > > > So I would like to drop this patch for 4.14 as this header file does not > > exist for 4.14. > > > > > > drivers/tty/serial/sh-sci.c:40:10: fatal error: linux/minmax.h: No such > > file or directory > > > 40 | #include > > > | ^~~~~~~~~~~~~~~~ > > > > Yes, minmax is not there, but the function needed by that is there (hint, I > > had to remove that include in 4.19). Remove it and see the next error you > > get :) > > > > OK got it, The SCIx_TEI_IRQ is introduced after 4.18 by patch [1]. > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/drivers/tty/serial/sh-sci.c?h=linux-5.4.y&id=628c534ae73581fd21a09a27b7a4222b01a44d64 > > So, 4.14 does not require this patch, as it have combined interrupt. Great, thanks for checking, it turns out that the Fixes: tag was wrong :(