From: Tony Lindgren <tony@atomide.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Johan Hovold" <johan@kernel.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-omap@vger.kernel.org, linux-serial@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: Clear port->pm on port specific driver unbind
Date: Fri, 14 Apr 2023 08:47:26 +0300 [thread overview]
Message-ID: <20230414054726.GE36234@atomide.com> (raw)
In-Reply-To: <ZDgoi2mFYYqswAhu@smile.fi.intel.com>
* Andy Shevchenko <andriy.shevchenko@linux.intel.com> [230413 16:06]:
> On Thu, Apr 13, 2023 at 10:03:41AM +0300, Tony Lindgren wrote:
> > Let's fix the issue by clearing port->pm in serial8250_unregister_port().
>
> Sounds to me like a fix that needs a Fixes tag.
Maybe commit c161afe9759d ("8250: allow platforms to override PM hook.").
That's a bit unclear though as the hardware specific functions were
available at that point as they were passed in platform data. This can
be seen with git blame c161afe9759d drivers/serial/8250.c. To me it seems
the port->pm became potentially invalid if a serial port device driver
started implementing PM runtime?
Maybe just tagging it with Cc: stable is better if no obvious Fixes tag
can be figured out.
> Code wise LGTM,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
OK thanks,
Tony
next prev parent reply other threads:[~2023-04-14 5:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 7:03 [PATCH] serial: 8250: Clear port->pm on port specific driver unbind Tony Lindgren
2023-04-13 16:06 ` Andy Shevchenko
2023-04-14 5:47 ` Tony Lindgren [this message]
2023-04-14 7:35 ` Ilpo Järvinen
2023-04-14 9:40 ` Tony Lindgren
2023-04-18 9:41 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230414054726.GE36234@atomide.com \
--to=tony@atomide.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).