From: Tony Lindgren <tony@atomide.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: omap: Move uart_write() inside PM section
Date: Mon, 15 May 2023 15:23:56 +0300 [thread overview]
Message-ID: <20230515122356.GI14287@atomide.com> (raw)
In-Reply-To: <20230515065706.1723477-1-geert@linux-m68k.org>
* Geert Uytterhoeven <geert@linux-m68k.org> [230515 06:57]:
> If CONFIG_PM is not set (e.g. m68k/allmodconfig):
>
> drivers/tty/serial/8250/8250_omap.c:169:13: error: ‘uart_write’ defined but not used [-Werror=unused-function]
> 169 | static void uart_write(struct omap8250_priv *priv, u32 reg, u32 val)
> | ^~~~~~~~~~
>
> Fix tis by moving uart_write() inside the existing section protected
> by #ifdef CONFIG_PM.
OK thanks for fixing it:
Reviewed-by: Tony Lindgren <tony@atomide.com>
prev parent reply other threads:[~2023-05-15 12:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 6:57 [PATCH] serial: 8250: omap: Move uart_write() inside PM section Geert Uytterhoeven
2023-05-15 12:23 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230515122356.GI14287@atomide.com \
--to=tony@atomide.com \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).