From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EA18C77B7D for ; Mon, 15 May 2023 12:24:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240137AbjEOMYA (ORCPT ); Mon, 15 May 2023 08:24:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229679AbjEOMX7 (ORCPT ); Mon, 15 May 2023 08:23:59 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3882CE5A; Mon, 15 May 2023 05:23:58 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 48E6D80DE; Mon, 15 May 2023 12:23:57 +0000 (UTC) Date: Mon, 15 May 2023 15:23:56 +0300 From: Tony Lindgren To: Geert Uytterhoeven Cc: Greg Kroah-Hartman , Jiri Slaby , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] serial: 8250: omap: Move uart_write() inside PM section Message-ID: <20230515122356.GI14287@atomide.com> References: <20230515065706.1723477-1-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230515065706.1723477-1-geert@linux-m68k.org> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org * Geert Uytterhoeven [230515 06:57]: > If CONFIG_PM is not set (e.g. m68k/allmodconfig): > > drivers/tty/serial/8250/8250_omap.c:169:13: error: ‘uart_write’ defined but not used [-Werror=unused-function] > 169 | static void uart_write(struct omap8250_priv *priv, u32 reg, u32 val) > | ^~~~~~~~~~ > > Fix tis by moving uart_write() inside the existing section protected > by #ifdef CONFIG_PM. OK thanks for fixing it: Reviewed-by: Tony Lindgren