linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Hongyu Xie <xiehongyu1@kylinos.cn>
Cc: linux@armlinux.org.uk, jirislaby@kernel.org,
	linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	xy521521@gmail.com
Subject: Re: [RFC PATCH -next] tty: serial: add panic serial helper
Date: Wed, 17 May 2023 13:55:52 +0200	[thread overview]
Message-ID: <2023051700-applied-briskly-61f1@gregkh> (raw)
In-Reply-To: <20230517101403.232594-1-xiehongyu1@kylinos.cn>

On Wed, May 17, 2023 at 06:14:03PM +0800, Hongyu Xie wrote:
> +config PANIC_SERIAL_HELPER
> +	tristate "debug through uart when panic"
> +	depends on PANIC_TIMEOUT=0
> +	select CONSOLE_POLL
> +	default m

No need to set this default, unless it is required to boot/run properly
with this value.

> +	help
> +	    Debug through uart when kernel panic happens.
> +	    This module helps you to get full kernel message through uart.
> +	    Say Y if you want add this to built-in kernel.
> +	    Say M if you want add this as a module driver.

What will the module name be?

And you need a lot more description here to explain what this is and why
anyone would want it and how it is to be used.

thanks,

greg k-h

  parent reply	other threads:[~2023-05-17 11:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-17 10:14 [RFC PATCH -next] tty: serial: add panic serial helper Hongyu Xie
2023-05-17 11:54 ` Greg KH
2023-05-17 11:55 ` Greg KH [this message]
2023-05-17 11:56 ` Greg KH
2023-05-17 11:57 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023051700-applied-briskly-61f1@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=xiehongyu1@kylinos.cn \
    --cc=xy521521@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).