From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 226E3C77B75 for ; Wed, 17 May 2023 11:55:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230350AbjEQLz5 (ORCPT ); Wed, 17 May 2023 07:55:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229999AbjEQLz5 (ORCPT ); Wed, 17 May 2023 07:55:57 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78B17136; Wed, 17 May 2023 04:55:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0DBC56394C; Wed, 17 May 2023 11:55:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 24830C433D2; Wed, 17 May 2023 11:55:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1684324555; bh=oUW+lsxwWuvrFiHnkrwu03GEz/ok7yytlXZEBkEXF5A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0v2ZR6Whytsc3FH5v+Qqkou5zgMYjS4SQXfPkNH7c36jSB9bgMFBEkw6vLzkkoz6m Mh/qD+CrMVHossMo1Lpu+z21679fnFhxWNIs/d0trsKGTm+K+EqxPiGgXZx7UB7rX2 5UYk5wu0Tra7MLDDp/jeixsUpBadftvYASqgINXs= Date: Wed, 17 May 2023 13:55:52 +0200 From: Greg KH To: Hongyu Xie Cc: linux@armlinux.org.uk, jirislaby@kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, xy521521@gmail.com Subject: Re: [RFC PATCH -next] tty: serial: add panic serial helper Message-ID: <2023051700-applied-briskly-61f1@gregkh> References: <20230517101403.232594-1-xiehongyu1@kylinos.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230517101403.232594-1-xiehongyu1@kylinos.cn> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Wed, May 17, 2023 at 06:14:03PM +0800, Hongyu Xie wrote: > +config PANIC_SERIAL_HELPER > + tristate "debug through uart when panic" > + depends on PANIC_TIMEOUT=0 > + select CONSOLE_POLL > + default m No need to set this default, unless it is required to boot/run properly with this value. > + help > + Debug through uart when kernel panic happens. > + This module helps you to get full kernel message through uart. > + Say Y if you want add this to built-in kernel. > + Say M if you want add this as a module driver. What will the module name be? And you need a lot more description here to explain what this is and why anyone would want it and how it is to be used. thanks, greg k-h