* Re: linux-next: Tree for May 15 (drivers/tty/serial/8250/8250_omap.c) [not found] <20230515141235.0777c631@canb.auug.org.au> @ 2023-05-16 2:40 ` Randy Dunlap 2023-05-17 5:51 ` Tony Lindgren 2023-05-16 2:51 ` linux-next: Tree for May 15 (config SERIAL_CPM) Randy Dunlap 1 sibling, 1 reply; 5+ messages in thread From: Randy Dunlap @ 2023-05-16 2:40 UTC (permalink / raw) To: Stephen Rothwell, Linux Next Mailing List Cc: Linux Kernel Mailing List, linux-serial, Greg Kroah-Hartman, Tony Lindgren On 5/14/23 21:12, Stephen Rothwell wrote: > Hi all, > > Changes since 20230512: > # CONFIG_PM is not set ../drivers/tty/serial/8250/8250_omap.c:169:13: warning: 'uart_write' defined but not used [-Wunused-function] 169 | static void uart_write(struct omap8250_priv *priv, u32 reg, u32 val) | ^~~~~~~~~~ -- ~Randy ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for May 15 (drivers/tty/serial/8250/8250_omap.c) 2023-05-16 2:40 ` linux-next: Tree for May 15 (drivers/tty/serial/8250/8250_omap.c) Randy Dunlap @ 2023-05-17 5:51 ` Tony Lindgren 0 siblings, 0 replies; 5+ messages in thread From: Tony Lindgren @ 2023-05-17 5:51 UTC (permalink / raw) To: Randy Dunlap Cc: Stephen Rothwell, Linux Next Mailing List, Linux Kernel Mailing List, linux-serial, Greg Kroah-Hartman, Geert Uytterhoeven * Randy Dunlap <rdunlap@infradead.org> [230516 02:40]: > > > On 5/14/23 21:12, Stephen Rothwell wrote: > > Hi all, > > > > Changes since 20230512: > > > > # CONFIG_PM is not set > > > ../drivers/tty/serial/8250/8250_omap.c:169:13: warning: 'uart_write' defined but not used [-Wunused-function] > 169 | static void uart_write(struct omap8250_priv *priv, u32 reg, u32 val) > | ^~~~~~~~~~ Thanks Geert has posted a fix for it: https://lore.kernel.org/linux-serial/20230515122356.GI14287@atomide.com/T/#t Regards, Tony ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for May 15 (config SERIAL_CPM) [not found] <20230515141235.0777c631@canb.auug.org.au> 2023-05-16 2:40 ` linux-next: Tree for May 15 (drivers/tty/serial/8250/8250_omap.c) Randy Dunlap @ 2023-05-16 2:51 ` Randy Dunlap 2023-05-18 5:49 ` Jiri Slaby 1 sibling, 1 reply; 5+ messages in thread From: Randy Dunlap @ 2023-05-16 2:51 UTC (permalink / raw) To: Stephen Rothwell, Linux Next Mailing List Cc: Linux Kernel Mailing List, Jiri Slaby, linux-serial On 5/14/23 21:12, Stephen Rothwell wrote: > Hi all, > > Changes since 20230512: > commit e3e7b13bffae Author: Jiri Slaby <jirislaby@kernel.org> Date: Thu Apr 21 12:17:08 2022 +0200 serial: allow COMPILE_TEST for some drivers See this portion of that commit: --- a/drivers/tty/serial/Kconfig +++ b/drivers/tty/serial/Kconfig @@ -783,7 +783,7 @@ config SERIAL_PMACZILOG_CONSOLE config SERIAL_CPM tristate "CPM SCC/SMC serial port support" - depends on CPM2 || CPM1 + depends on CPM2 || CPM1 || (PPC32 && COMPILE_TEST) When PPC32=y and COMPILE_TEST=y but CPM1 is not set and CPM2 is not set: /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_release_port': cpm_uart_core.c:(.text+0x598): undefined reference to `cpm_uart_freebuf' /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_set_termios': cpm_uart_core.c:(.text+0x8e0): undefined reference to `__cpm2_setbrg' /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_break_ctl': cpm_uart_core.c:(.text+0xb10): undefined reference to `cpm_line_cr_cmd' /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0xb6c): undefined reference to `cpm_line_cr_cmd' /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_startup': cpm_uart_core.c:(.text+0x1d48): undefined reference to `cpm_line_cr_cmd' /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_request_port': cpm_uart_core.c:(.text+0x1ddc): undefined reference to `cpm_uart_allocbuf' /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0x2170): undefined reference to `cpm_line_cr_cmd' /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_probe': cpm_uart_core.c:(.text+0x2474): undefined reference to `cpm_uart_map_pram' /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0x2724): undefined reference to `cpm_uart_unmap_pram' /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0x2838): undefined reference to `cpm_uart_map_pram' /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_shutdown': cpm_uart_core.c:(.text+0x2aa8): undefined reference to `cpm_line_cr_cmd' /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0x2ba4): undefined reference to `cpm_line_cr_cmd' -- ~Randy ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for May 15 (config SERIAL_CPM) 2023-05-16 2:51 ` linux-next: Tree for May 15 (config SERIAL_CPM) Randy Dunlap @ 2023-05-18 5:49 ` Jiri Slaby 2023-05-18 5:50 ` Jiri Slaby 0 siblings, 1 reply; 5+ messages in thread From: Jiri Slaby @ 2023-05-18 5:49 UTC (permalink / raw) To: Randy Dunlap, Stephen Rothwell, Linux Next Mailing List, Greg KH Cc: Linux Kernel Mailing List, linux-serial On 16. 05. 23, 4:51, Randy Dunlap wrote: > > > On 5/14/23 21:12, Stephen Rothwell wrote: >> Hi all, >> >> Changes since 20230512: >> > > commit e3e7b13bffae > Author: Jiri Slaby <jirislaby@kernel.org> > Date: Thu Apr 21 12:17:08 2022 +0200 > > serial: allow COMPILE_TEST for some drivers That commit should be reverted. I didn't realize it wouldn't link, while it compiles fine. > See this portion of that commit: > > --- a/drivers/tty/serial/Kconfig > +++ b/drivers/tty/serial/Kconfig > @@ -783,7 +783,7 @@ config SERIAL_PMACZILOG_CONSOLE > > config SERIAL_CPM > tristate "CPM SCC/SMC serial port support" > - depends on CPM2 || CPM1 > + depends on CPM2 || CPM1 || (PPC32 && COMPILE_TEST) > > > When PPC32=y and COMPILE_TEST=y but CPM1 is not set and CPM2 is not set: > > /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_release_port': > cpm_uart_core.c:(.text+0x598): undefined reference to `cpm_uart_freebuf' > /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_set_termios': > cpm_uart_core.c:(.text+0x8e0): undefined reference to `__cpm2_setbrg' > /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_break_ctl': > cpm_uart_core.c:(.text+0xb10): undefined reference to `cpm_line_cr_cmd' > /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0xb6c): undefined reference to `cpm_line_cr_cmd' > /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_startup': > cpm_uart_core.c:(.text+0x1d48): undefined reference to `cpm_line_cr_cmd' > /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_request_port': > cpm_uart_core.c:(.text+0x1ddc): undefined reference to `cpm_uart_allocbuf' > /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0x2170): undefined reference to `cpm_line_cr_cmd' > /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_probe': > cpm_uart_core.c:(.text+0x2474): undefined reference to `cpm_uart_map_pram' > /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0x2724): undefined reference to `cpm_uart_unmap_pram' > /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0x2838): undefined reference to `cpm_uart_map_pram' > /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: drivers/tty/serial/cpm_uart/cpm_uart_core.o: in function `cpm_uart_shutdown': > cpm_uart_core.c:(.text+0x2aa8): undefined reference to `cpm_line_cr_cmd' > /opt/crosstool/gcc-12.2.0-nolibc/powerpc-linux/bin/powerpc-linux-ld: cpm_uart_core.c:(.text+0x2ba4): undefined reference to `cpm_line_cr_cmd' > > -- js suse labs ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: linux-next: Tree for May 15 (config SERIAL_CPM) 2023-05-18 5:49 ` Jiri Slaby @ 2023-05-18 5:50 ` Jiri Slaby 0 siblings, 0 replies; 5+ messages in thread From: Jiri Slaby @ 2023-05-18 5:50 UTC (permalink / raw) To: Randy Dunlap, Stephen Rothwell, Linux Next Mailing List, Greg KH Cc: Linux Kernel Mailing List, linux-serial On 18. 05. 23, 7:49, Jiri Slaby wrote: > On 16. 05. 23, 4:51, Randy Dunlap wrote: >> >> >> On 5/14/23 21:12, Stephen Rothwell wrote: >>> Hi all, >>> >>> Changes since 20230512: >>> >> >> commit e3e7b13bffae >> Author: Jiri Slaby <jirislaby@kernel.org> >> Date: Thu Apr 21 12:17:08 2022 +0200 >> >> serial: allow COMPILE_TEST for some drivers > > That commit should be reverted * partially. The rest appears to be OK. I will send a fix shortly. -- js suse labs ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-05-18 5:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20230515141235.0777c631@canb.auug.org.au>
2023-05-16 2:40 ` linux-next: Tree for May 15 (drivers/tty/serial/8250/8250_omap.c) Randy Dunlap
2023-05-17 5:51 ` Tony Lindgren
2023-05-16 2:51 ` linux-next: Tree for May 15 (config SERIAL_CPM) Randy Dunlap
2023-05-18 5:49 ` Jiri Slaby
2023-05-18 5:50 ` Jiri Slaby
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).