From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36294C7EE2A for ; Thu, 1 Jun 2023 14:21:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234244AbjFAOVz (ORCPT ); Thu, 1 Jun 2023 10:21:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233745AbjFAOVo (ORCPT ); Thu, 1 Jun 2023 10:21:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 608AA129; Thu, 1 Jun 2023 07:21:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E643A645B0; Thu, 1 Jun 2023 14:21:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DFC9CC433EF; Thu, 1 Jun 2023 14:21:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1685629302; bh=oLpYviaXLu1mw3F44Ygtatzq0x8d0upsGXVBIfIWE+8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=I6uG9eY6HmCHLCDNh/fD3hA8v9JMRZ9dhCTPBCC6WGQMiBcTrgiX0LbSxSRpGax9N MbTf51GdsFfnRq/3qZ7X4oEUTNzgf2ZaCNLnv9kWeCavdQaatJ+3jMkM9H7iaA5EUb gVGpfAuNVPSL+t3+Ir70lxYQ8EvBPHG4F/EXoTTY= Date: Thu, 1 Jun 2023 15:21:40 +0100 From: Greg Kroah-Hartman To: Tony Lindgren Cc: Jiri Slaby , Andy Shevchenko , Andy Shevchenko , Dhruva Gole , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-omap@vger.kernel.org, Marek Szyprowski , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] serial: core: Fix probing serial_base_bus devices Message-ID: <2023060112-onion-disparate-8ce8@gregkh> References: <20230601141445.11321-1-tony@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230601141445.11321-1-tony@atomide.com> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Thu, Jun 01, 2023 at 05:14:44PM +0300, Tony Lindgren wrote: > If a physical serial port device driver uses arch_initcall() we fail to > probe the serial_base_bus devices and the serial port tx fails. This is > because as serial_base_bus uses module_initcall(). > > Let's fix the issue by changing serial_base_bus to use arch_initcall(). This will only work if the linking order is such that this will always come before the drivers. Is that the case here? thanks, greg k-h