From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB944C77B7E for ; Thu, 1 Jun 2023 15:44:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233972AbjFAPox (ORCPT ); Thu, 1 Jun 2023 11:44:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46164 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234619AbjFAPor (ORCPT ); Thu, 1 Jun 2023 11:44:47 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A4FA4136; Thu, 1 Jun 2023 08:44:37 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 2793E646D1; Thu, 1 Jun 2023 15:44:37 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1C6C8C4339B; Thu, 1 Jun 2023 15:44:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1685634276; bh=DqnmHsGETvKUOxciKJwJgUxc/bfquKkln00h6FokanM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=htB3jkipoBCacSu4F2LqM/7ySFNoqm+YAEJtNT1zH1sMPGEgILC4KRF+WDfSmOfzA ACw7rcP5ysXsvHn8nHLQhGRlIBZaXOk3PA8JLXtzJPAahDL82jmlgwZ13bKGDAFJ0K 1AhRxiMDLHYmru3eo4CKuK0aQLIe7hcjtvOOO1ds= Date: Thu, 1 Jun 2023 16:44:34 +0100 From: Greg Kroah-Hartman To: Marek Szyprowski Cc: Tony Lindgren , Jiri Slaby , Andy Shevchenko , Andy Shevchenko , Dhruva Gole , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-omap@vger.kernel.org, linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] serial: core: Fix probing serial_base_bus devices Message-ID: <2023060123-shelf-bagging-4463@gregkh> References: <20230601141445.11321-1-tony@atomide.com> <2023060112-onion-disparate-8ce8@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Thu, Jun 01, 2023 at 05:09:52PM +0200, Marek Szyprowski wrote: > On 01.06.2023 16:21, Greg Kroah-Hartman wrote: > > On Thu, Jun 01, 2023 at 05:14:44PM +0300, Tony Lindgren wrote: > >> If a physical serial port device driver uses arch_initcall() we fail to > >> probe the serial_base_bus devices and the serial port tx fails. This is > >> because as serial_base_bus uses module_initcall(). > >> > >> Let's fix the issue by changing serial_base_bus to use arch_initcall(). > > This will only work if the linking order is such that this will always > > come before the drivers. Is that the case here? > > Yes, serial_base_bus is linked as a second object, just after the > serial_core. Device drivers come later. Oh good, I guess it wouldn't work at all as the serial_core is needed by all of those drivers first too, so this should work, thanks for checking. greg k-h