From: Hugo Villeneuve <hugo@hugovil.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
jirislaby@kernel.org, jringle@gridpoint.com,
tomasz.mon@camlingroup.com, l.perczak@camlintechnologies.com,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v6 5/9] serial: sc16is7xx: fix regression with GPIO configuration
Date: Fri, 2 Jun 2023 09:06:29 -0400 [thread overview]
Message-ID: <20230602090629.aa1bee802aafae76ce4e1e60@hugovil.com> (raw)
In-Reply-To: <CAHp75VcLNRQyeo4H-auDvk+CxZ0hz+2pysqP3bBgW-uZB_2vPw@mail.gmail.com>
On Fri, 2 Jun 2023 15:58:43 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Fri, Jun 2, 2023 at 4:25 AM Hugo Villeneuve <hugo@hugovil.com> wrote:
> > On Thu, 1 Jun 2023 20:41:40 -0400
> > Hugo Villeneuve <hugo@hugovil.com> wrote:
> > > On Fri, 2 Jun 2023 00:30:14 +0300
> > > andy.shevchenko@gmail.com wrote:
> > > > Thu, Jun 01, 2023 at 04:18:40PM -0400, Hugo Villeneuve kirjoitti:
>
> ...
>
> > > > Maybe positive one?
> > > > if (mctrl_mask)
> > > > regmap_update_bits(...);
> > >
> > > I used negative to save on indentation, but it also fits by converting it to positive, so done.
>
> I understand, but in this case it is slightly more weird to have
> negative conditional and in either case return the value of the local
> variable.
Yes.
> > Greg did not yet respond to my email about the proposed tags, but if the new order of the patches and the stable tags I added seems ok to you, I will resend V7. It will then probably easier for Greg to comment directly on V7 for the stable tags (Cc:).
>
> They look fine to me, but Greg is the maintainer, he decides if it's
> really okay or not.
Then I will submit V7 now.
Thank you,
Hugo.
next prev parent reply other threads:[~2023-06-02 13:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-01 20:18 [PATCH v6 0/9] serial: sc16is7xx: fix GPIO regression and rs485 improvements Hugo Villeneuve
2023-06-01 20:18 ` [PATCH v6 1/9] serial: sc16is7xx: fix broken port 0 uart init Hugo Villeneuve
2023-06-01 20:18 ` [PATCH v6 2/9] serial: sc16is7xx: mark IOCONTROL register as volatile Hugo Villeneuve
2023-06-01 20:18 ` [PATCH v6 3/9] serial: sc16is7xx: refactor GPIO controller registration Hugo Villeneuve
2023-06-01 20:18 ` [PATCH v6 4/9] dt-bindings: sc16is7xx: Add property to change GPIO function Hugo Villeneuve
2023-06-01 20:18 ` [PATCH v6 5/9] serial: sc16is7xx: fix regression with GPIO configuration Hugo Villeneuve
2023-06-01 21:30 ` andy.shevchenko
2023-06-02 0:41 ` Hugo Villeneuve
2023-06-02 1:25 ` Hugo Villeneuve
2023-06-02 12:58 ` Andy Shevchenko
2023-06-02 13:06 ` Hugo Villeneuve [this message]
2023-06-01 20:18 ` [PATCH v6 6/9] serial: sc16is7xx: fix bug when first setting GPIO direction Hugo Villeneuve
2023-06-01 20:18 ` [PATCH v6 7/9] serial: sc16is7xx: add call to get rs485 DT flags and properties Hugo Villeneuve
2023-06-01 20:18 ` [PATCH v6 8/9] serial: sc16is7xx: add post reset delay Hugo Villeneuve
2023-06-01 20:18 ` [PATCH v6 9/9] serial: sc16is7xx: improve comments about variants Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230602090629.aa1bee802aafae76ce4e1e60@hugovil.com \
--to=hugo@hugovil.com \
--cc=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=jringle@gridpoint.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.perczak@camlintechnologies.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tomasz.mon@camlingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox