From: Hugo Villeneuve <hugo@hugovil.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, jirislaby@kernel.org, jringle@gridpoint.com,
tomasz.mon@camlingroup.com, l.perczak@camlintechnologies.com,
linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
Hugo Villeneuve <hvilleneuve@dimonoff.com>,
stable@vger.kernel.org
Subject: Re: [PATCH v7 5/9] serial: sc16is7xx: fix regression with GPIO configuration
Date: Sun, 4 Jun 2023 13:44:59 -0400 [thread overview]
Message-ID: <20230604134459.3c3844012e9714fa2a61e642@hugovil.com> (raw)
In-Reply-To: <CAHp75Ve6W-hcB4YAeKukgv-uOEzBY7Tx5Sdf3doTRYKzNPcVGw@mail.gmail.com>
On Sun, 4 Jun 2023 14:57:31 +0300
Andy Shevchenko <andy.shevchenko@gmail.com> wrote:
> On Sun, Jun 4, 2023 at 10:47 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> > On Fri, Jun 02, 2023 at 11:26:21AM -0400, Hugo Villeneuve wrote:
>
> ...
>
> > > +static u8 sc16is7xx_setup_mctrl_ports(struct device *dev)
> >
> > This returns what, mctrl? If so, please document that, it doesn't look
> > obvious.
>
> Good suggestion. Because I also stumbled over the returned type.
>
> > And as the kernel test robot reported, you do nothing with the
> > return value so why compute it?
>
> It seems that the entire function and respective call has to be moved
> under #ifdef CONFIG_GPIOLIB.
Hi,
it cannot. See my explanations in response to Greg's comments.
Hugo.
next prev parent reply other threads:[~2023-06-04 17:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-02 15:26 [PATCH v7 0/9] serial: sc16is7xx: fix GPIO regression and rs485 improvements Hugo Villeneuve
2023-06-02 15:26 ` [PATCH v7 1/9] serial: sc16is7xx: fix broken port 0 uart init Hugo Villeneuve
2023-06-02 15:26 ` [PATCH v7 2/9] serial: sc16is7xx: mark IOCONTROL register as volatile Hugo Villeneuve
2023-06-02 15:26 ` [PATCH v7 3/9] serial: sc16is7xx: refactor GPIO controller registration Hugo Villeneuve
2023-06-02 15:26 ` [PATCH v7 4/9] dt-bindings: sc16is7xx: Add property to change GPIO function Hugo Villeneuve
2023-06-02 15:26 ` [PATCH v7 5/9] serial: sc16is7xx: fix regression with GPIO configuration Hugo Villeneuve
2023-06-02 21:46 ` kernel test robot
2023-06-04 7:47 ` Greg KH
2023-06-04 11:57 ` Andy Shevchenko
2023-06-04 17:44 ` Hugo Villeneuve [this message]
2023-06-04 19:31 ` Andy Shevchenko
2023-06-05 17:53 ` Hugo Villeneuve
2023-06-20 14:08 ` Hugo Villeneuve
2023-06-20 15:18 ` Andy Shevchenko
2023-06-20 15:33 ` Hugo Villeneuve
2023-06-20 15:35 ` Andy Shevchenko
2023-06-20 15:42 ` Hugo Villeneuve
2023-06-20 15:45 ` Andy Shevchenko
2023-06-20 16:16 ` Hugo Villeneuve
2023-07-19 18:40 ` Hugo Villeneuve
2023-07-19 19:14 ` Greg KH
2023-07-20 19:38 ` Greg KH
2023-07-21 15:25 ` Hugo Villeneuve
2023-07-21 15:40 ` Greg KH
2023-07-21 15:46 ` Hugo Villeneuve
2023-06-04 17:43 ` Hugo Villeneuve
2023-06-04 18:29 ` Greg KH
2023-06-04 23:16 ` Hugo Villeneuve
2023-06-05 17:57 ` Hugo Villeneuve
2023-06-07 14:07 ` Hugo Villeneuve
2023-06-02 15:26 ` [PATCH v7 6/9] serial: sc16is7xx: fix bug when first setting GPIO direction Hugo Villeneuve
2023-06-02 15:26 ` [PATCH v7 7/9] serial: sc16is7xx: add call to get rs485 DT flags and properties Hugo Villeneuve
2023-06-02 15:26 ` [PATCH v7 8/9] serial: sc16is7xx: add post reset delay Hugo Villeneuve
2023-06-02 15:26 ` [PATCH v7 9/9] serial: sc16is7xx: improve comments about variants Hugo Villeneuve
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230604134459.3c3844012e9714fa2a61e642@hugovil.com \
--to=hugo@hugovil.com \
--cc=andy.shevchenko@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hvilleneuve@dimonoff.com \
--cc=jirislaby@kernel.org \
--cc=jringle@gridpoint.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.perczak@camlintechnologies.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stable@vger.kernel.org \
--cc=tomasz.mon@camlingroup.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox