From: Bjorn Andersson <andersson@kernel.org>
To: "Mehul Raninga (Temp) (QUIC)" <quic_mraninga@quicinc.com>
Cc: "agross@kernel.org" <agross@kernel.org>,
"konrad.dybcio@linaro.org" <konrad.dybcio@linaro.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"jirislaby@kernel.org" <jirislaby@kernel.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Viken Dadhaniya (QUIC)" <quic_vdadhani@quicinc.com>,
"Visweswara Tanuku (QUIC)" <quic_vtanuku@quicinc.com>,
"Vijaya Krishna Nivarthi (Temp) (QUIC)"
<quic_vnivarth@quicinc.com>
Subject: Re: [PATCH] serial: qcom_geni_serial: Setup serial port after Deep sleep
Date: Sat, 10 Jun 2023 09:48:37 -0700 [thread overview]
Message-ID: <20230610164837.gjncik7aasvfqhe7@ripper> (raw)
In-Reply-To: <CO6PR02MB7731BA49B9EBDC82E801F745E34EA@CO6PR02MB7731.namprd02.prod.outlook.com>
On Fri, Jun 02, 2023 at 06:39:02AM +0000, Mehul Raninga (Temp) (QUIC) wrote:
[..]
> > On Wed, May 31, 2023 at 01:06:22PM +0000, Mehul Raninga (Temp)
> > (QUIC) wrote:
[..]
> > > > > + if (pm_suspend_via_firmware())
> > > >
> > > > I'm not familiar with this api, but aren't all our systems
> > > > implementing firmware- assisted suspend?
> > >
> > > Not all the platform supports deep sleep hence to differentiate if
> > > resume is from deep sleep suspend or normal suspend, this api is
> > > required.
> >
> > Can you point me to where this difference in flags is coming from in the
> > upstream kernel?
>
> In upstream kernel by default the flag is false, and for deepsleep
> support vendor kernel sets this flag true.
I am questioning whether this is correct, given that we indeed "suspend
with the help of firmware". But I might be misinterpreting what that
statement means.
Regards,
Bjorn
prev parent reply other threads:[~2023-06-10 16:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-30 11:15 [PATCH] serial: qcom_geni_serial: Setup serial port after Deep sleep Mehul Raninga
2023-05-30 15:06 ` Bjorn Andersson
2023-05-31 13:06 ` Mehul Raninga (Temp) (QUIC)
2023-06-01 4:07 ` Bjorn Andersson
2023-06-02 6:39 ` Mehul Raninga (Temp) (QUIC)
2023-06-10 16:48 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230610164837.gjncik7aasvfqhe7@ripper \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=quic_mraninga@quicinc.com \
--cc=quic_vdadhani@quicinc.com \
--cc=quic_vnivarth@quicinc.com \
--cc=quic_vtanuku@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox