linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	linux-serial@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] serial: core: don't kfree device managed data
Date: Wed, 14 Jun 2023 07:46:07 +0300	[thread overview]
Message-ID: <20230614044607.GF14287@atomide.com> (raw)
In-Reply-To: <20230606161840.GL56720@atomide.com>

Hi Dan,

* Tony Lindgren <tony@atomide.com> [230606 19:18]:
> * Dan Carpenter <dan.carpenter@linaro.org> [230606 15:01]:
> > On Tue, Jun 06, 2023 at 05:55:16PM +0300, Andy Shevchenko wrote:
> > > 
> > > I'm okay with the above, but it seems at the same time we need to limit the
> > > messages:
> > > 
> > > 	dev_err_once(port->dev, "uart_add_one_port() called before arch_initcall()?\n");
> > > 
> > 
> > Yeah.  I would prefer if that was only printed as a debug message.
> > -EPROBE_DEFER is supposed to be a normal part of the process.
> 
> Debug here should do the trick yeah.

Just wondering.. Are you going to send this fix or do you want me to type
it up?

Regards,

Tony

  reply	other threads:[~2023-06-14  4:46 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-06  8:26 [PATCH] serial: core: don't kfree device managed data Dan Carpenter
2023-06-06 12:28 ` Tony Lindgren
2023-06-06 13:17   ` Andy Shevchenko
2023-06-06 16:23     ` Tony Lindgren
2023-06-06 13:16 ` Andy Shevchenko
2023-06-06 13:37   ` Tony Lindgren
2023-06-06 14:54     ` Andy Shevchenko
2023-06-06 16:21       ` Tony Lindgren
2023-06-06 13:51   ` Dan Carpenter
2023-06-06 14:55     ` Andy Shevchenko
2023-06-06 15:01       ` Dan Carpenter
2023-06-06 16:18         ` Tony Lindgren
2023-06-14  4:46           ` Tony Lindgren [this message]
2023-06-14  6:37             ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230614044607.GF14287@atomide.com \
    --to=tony@atomide.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dan.carpenter@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).