From: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>
To: gregkh@linuxfoundation.org
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
"Jiri Slaby (SUSE)" <jirislaby@kernel.org>
Subject: [PATCH 1/6] tty_audit: use TASK_COMM_LEN for task comm
Date: Wed, 21 Jun 2023 12:16:06 +0200 [thread overview]
Message-ID: <20230621101611.10580-2-jirislaby@kernel.org> (raw)
In-Reply-To: <20230621101611.10580-1-jirislaby@kernel.org>
This is the preferred way of declaring an array for get_task_comm().
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
---
drivers/tty/tty_audit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/tty/tty_audit.c b/drivers/tty/tty_audit.c
index ca7afd7b2716..b98b1aef5f6f 100644
--- a/drivers/tty/tty_audit.c
+++ b/drivers/tty/tty_audit.c
@@ -69,7 +69,7 @@ static void tty_audit_log(const char *description, dev_t dev,
ab = audit_log_start(audit_context(), GFP_KERNEL, AUDIT_TTY);
if (ab) {
- char name[sizeof(current->comm)];
+ char name[TASK_COMM_LEN];
audit_log_format(ab, "%s pid=%u uid=%u auid=%u ses=%u major=%d"
" minor=%d comm=", description, pid, uid,
--
2.41.0
next prev parent reply other threads:[~2023-06-21 10:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 10:16 [PATCH 0/6] tty_audit: random cleanups Jiri Slaby (SUSE)
2023-06-21 10:16 ` Jiri Slaby (SUSE) [this message]
2023-06-21 10:16 ` [PATCH 2/6] tty_audit: use kzalloc() in tty_audit_buf_alloc() Jiri Slaby (SUSE)
2023-06-21 10:16 ` [PATCH 3/6] tty_audit: invert the condition in tty_audit_log() Jiri Slaby (SUSE)
2023-06-21 10:16 ` [PATCH 4/6] tty_audit: make icanon a bool Jiri Slaby (SUSE)
2023-06-21 10:16 ` [PATCH 5/6] tty_audit: make tty pointers in exposed functions const Jiri Slaby (SUSE)
2023-06-21 10:16 ` [PATCH 6/6] tty_audit: make data of tty_audit_log() const Jiri Slaby (SUSE)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621101611.10580-2-jirislaby@kernel.org \
--to=jirislaby@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).