From: Tony Lindgren <tony@atomide.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>
Cc: "Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Dhruva Gole" <d-gole@ti.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Johan Hovold" <johan@kernel.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: [PATCH v5 0/3] Serial core controller port device name fixes
Date: Tue, 25 Jul 2023 08:42:09 +0300 [thread overview]
Message-ID: <20230725054216.45696-1-tony@atomide.com> (raw)
A few issues have been found with device naming for the serial core
controller port device. These issues currently mostly affect the output
for /sys/bus/serial-base/devices, but need to be also fixed to avoid
port addressing issues later on.
Changes since v4:
- Make the sysfs device names nicer with DEVNAME:0.0 naming, the "ctrl"
and "port" prefixes are not needed with the controller id in the name
- Fix Andy's Reviewed-by as noted by Andy
- Generate patches with --patience to make the last patch more readable
Changes since v3:
- Drop unnecessary else on the return path in serial_base_device_init()
as noted by Andy
- Add Andy's Reviewed-by
- Update patch description for port_id instead of port port_id for the
first patch
Changes since v2:
- Fix my email script as it had started to drop linux-serial as noted by
Greg
- Explain why we're changing ctrl_id as requested by Greg
Changes since v1:
- Port id cannot be negative as noted by Jiri
- Controller id cannot be negative as noted by Andy
- Port name is missing the controller instance as noted by Andy
Tony Lindgren (3):
serial: core: Controller id cannot be negative
serial: core: Fix serial core port id to not use port->line
serial: core: Fix serial core controller port name to show controller
id
drivers/tty/serial/8250/8250_core.c | 2 ++
drivers/tty/serial/serial_base_bus.c | 32 +++++++++++++++++-----------
include/linux/serial_core.h | 3 ++-
3 files changed, 24 insertions(+), 13 deletions(-)
--
2.41.0
next reply other threads:[~2023-07-25 5:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 5:42 Tony Lindgren [this message]
2023-07-25 5:42 ` [PATCH v5 1/3] serial: core: Controller id cannot be negative Tony Lindgren
2023-07-25 5:42 ` [PATCH v5 2/3] serial: core: Fix serial core port id to not use port->line Tony Lindgren
2023-07-25 5:42 ` [PATCH v5 3/3] serial: core: Fix serial core controller port name to show controller id Tony Lindgren
2023-07-25 9:07 ` Andy Shevchenko
2023-07-26 3:28 ` Tony Lindgren
2023-07-31 15:14 ` Greg Kroah-Hartman
2023-07-31 20:02 ` Andy Shevchenko
[not found] ` <202308021529.35b3ad6c-oliver.sang@intel.com>
2023-08-02 9:23 ` Tony Lindgren
2023-08-02 9:39 ` Greg Kroah-Hartman
2023-08-02 10:47 ` Tony Lindgren
2023-08-02 11:52 ` Tony Lindgren
2023-08-02 18:19 ` Mark Brown
2023-08-03 6:52 ` Tony Lindgren
2023-08-03 22:18 ` Guenter Roeck
2023-08-04 4:20 ` Andy Shevchenko
2023-08-04 4:38 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230725054216.45696-1-tony@atomide.com \
--to=tony@atomide.com \
--cc=andriy.shevchenko@intel.com \
--cc=bigeasy@linutronix.de \
--cc=d-gole@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).