From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Sherry Sun <sherry.sun@nxp.com>
Cc: Jiri Slaby <jirislaby@kernel.org>,
"tomonori.sakita@sord.co.jp" <tomonori.sakita@sord.co.jp>,
"atsushi.nemoto@sord.co.jp" <atsushi.nemoto@sord.co.jp>,
"linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH] tty: serial: fsl_lpuart: Clear the error flags by writing 1 for lpuart32 platforms
Date: Mon, 31 Jul 2023 17:13:15 +0200 [thread overview]
Message-ID: <2023073106-disallow-sketch-c5cf@gregkh> (raw)
In-Reply-To: <AS8PR04MB8404AA5CD478CD6AEEFC42A29205A@AS8PR04MB8404.eurprd04.prod.outlook.com>
On Mon, Jul 31, 2023 at 05:50:46AM +0000, Sherry Sun wrote:
>
>
> > -----Original Message-----
> > From: Jiri Slaby <jirislaby@kernel.org>
> > Sent: 2023年7月31日 13:24
> > To: Sherry Sun <sherry.sun@nxp.com>; gregkh@linuxfoundation.org;
> > tomonori.sakita@sord.co.jp; atsushi.nemoto@sord.co.jp
> > Cc: linux-serial@vger.kernel.org; linux-kernel@vger.kernel.org; dl-linux-imx
> > <linux-imx@nxp.com>
> > Subject: Re: [PATCH] tty: serial: fsl_lpuart: Clear the error flags by writing 1
> > for lpuart32 platforms
> >
> > On 31. 07. 23, 3:50, Sherry Sun wrote:
> > > Do not read the data register to clear the error flags for lpuart32
> > > platforms, the additional read may cause the receive FIFO underflow
> > > since the DMA has already read the data register.
> > > Now all lpuart32 platforms support write 1 to clear those error bits,
> >
> > What does this "Now" mean? Will this change break some older platforms?
>
> Hi Jiri,
>
> Sorry for the confusion, maybe the "Now" should be removed here. I can
> send a V2 to improve the commit message if needed.
Please do, thanks!
greg k-h
prev parent reply other threads:[~2023-07-31 15:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 1:50 [PATCH] tty: serial: fsl_lpuart: Clear the error flags by writing 1 for lpuart32 platforms Sherry Sun
2023-07-31 5:23 ` Jiri Slaby
2023-07-31 5:50 ` Sherry Sun
2023-07-31 15:13 ` gregkh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023073106-disallow-sketch-c5cf@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=atsushi.nemoto@sord.co.jp \
--cc=jirislaby@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=sherry.sun@nxp.com \
--cc=tomonori.sakita@sord.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).