From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: oushixiong <oushixiong@kylinos.cn>
Cc: "Jiri Slaby" <jirislaby@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Samuel Thibault" <samuel.thibault@ens-lyon.org>,
"Daniel Vetter" <daniel.vetter@ffwll.ch>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v2] tty: vt: Remove some repetitive initialization
Date: Tue, 1 Aug 2023 15:23:46 +0200 [thread overview]
Message-ID: <2023080103-yearling-backfire-4875@gregkh> (raw)
In-Reply-To: <20230801115724.1428952-1-oushixiong@kylinos.cn>
On Tue, Aug 01, 2023 at 07:57:24PM +0800, oushixiong wrote:
>
> Members vc_col???vc_rows and vc_size_row of the struct vc_data have been
Odd ??? characters?
> initialized in visual_init(), so it no longer to initialized them again
> in vc_init().
>
> v1->v2:
> - Fix the comment.
This needs to be below the --- line, right?
>
> Signed-off-by: oushixiong <oushixiong@kylinos.cn>
> ---
> drivers/tty/vt/vt.c | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
thanks.
greg k-h
prev parent reply other threads:[~2023-08-01 13:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 11:57 [PATCH v2] tty: vt: Remove some repetitive initialization oushixiong
2023-08-01 13:23 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023080103-yearling-backfire-4875@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=daniel.vetter@ffwll.ch \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=oushixiong@kylinos.cn \
--cc=samuel.thibault@ens-lyon.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).