From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56B8DC001DE for ; Wed, 2 Aug 2023 09:40:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233425AbjHBJkD (ORCPT ); Wed, 2 Aug 2023 05:40:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233316AbjHBJkB (ORCPT ); Wed, 2 Aug 2023 05:40:01 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C320410F5; Wed, 2 Aug 2023 02:40:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5393D618D5; Wed, 2 Aug 2023 09:40:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 368DBC433B8; Wed, 2 Aug 2023 09:39:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1690969199; bh=5qyLw2eCvjE4uVaT/oZ8daKDgkw06796ejPXw8VCLBo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=J2vZZ5qN39mXGahqcryN2Aew9We10H/jpToK2guoWec1FzFP4mEZhNBs+uNf5SrIW vvUEvdqnnZ2RoOVBfpPv6QUCDoCocqNH6XcWvE5WUkXeYrbyxM6rBgNjb1/ceGCjYZ nzJ5oRRs6y4ojmS3phx/+4mRhQErpxCHNJt903Ds= Date: Wed, 2 Aug 2023 11:39:56 +0200 From: Greg Kroah-Hartman To: Tony Lindgren Cc: kernel test robot , oe-lkp@lists.linux.dev, lkp@intel.com, Andy Shevchenko , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Jiri Slaby , Andy Shevchenko , Dhruva Gole , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , John Ogness , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra Subject: Re: [PATCH v5 3/3] serial: core: Fix serial core controller port name to show controller id Message-ID: <2023080236-gurgling-violet-b54e@gregkh> References: <20230725054216.45696-4-tony@atomide.com> <202308021529.35b3ad6c-oliver.sang@intel.com> <20230802092354.GC14799@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230802092354.GC14799@atomide.com> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Wed, Aug 02, 2023 at 12:23:54PM +0300, Tony Lindgren wrote: > * kernel test robot [230802 08:16]: > > from serial, we observed last print out is: > > > > [ 15.584772][ T954] EDAC MC0: Giving out device to module skx_edac controller Skylake Socket#0 IMC#0: DEV 0000:3a:0a.0 (INTERRUPT) > > [ 15.597328][ T954] EDAC MC1: Giving out device to module skx_edac controller Skylake Socket#0 IMC#1: DEV 0000:3a:0c.0 (INTERRUPT) > > [ 15.610326][ T954] EDAC MC2: Giving out device to module skx_edac controller Skylake Socket#1 IMC#0: DEV 0000:ae:0a.0 (INTERRUPT) > > [ 15.623375][ T954] EDAC MC3: Giving out device to module skx_edac controller Skylake Socket#1 IMC#1: DEV 0000:ae:0c.0 (INTERRUPT) > > [ 15.640145][ T19] intel_rapl_common: Found RAPL domain package > > [ 15.655890][ T19] intel_rapl_common: Found RAPL domain dram > > [ 15.661983][ T19] intel_rapl_common: package-0:package:long_term locked by BIOS > > [ 15.678564][ T19] intel_rapl_common: package-0:package:short_term locked by BIOS > > [ 15.695259][ T19] intel_rapl_common: package-0:dram:long_term locked by BIOS > > [ 15.713068][ T158] intel_rapl_common: Found RAPL domain package > > [ 15.728719][ T158] intel_rapl_common: Found RAPL domain dram > > [ 15.734743][ T158] intel_rapl_common: package-1:package:long_term locked by BIOS > > [ 15.745244][ T1154] raid6: avx512x4 gen() 18153 MB/s > > [ 15.761297][ T158] intel_rapl_common: package-1:package:short_term locked by BIOS > > [ 15.767244][ T1154] raid6: avx512x2 gen() 18130 MB/s > > [ 15.768866][ T158] intel_rapl_common: package-1:dram:long_term locked by BIOS > > [ 15.790243][ T1154] raid6: avx512x1 gen() 18155 MB/s > > [ 15.812245][ T1154] raid6: avx2x4 gen() 18060 MB/s > > [ 15.834244][ T1154] raid6: avx2x2 gen() 18076 MB/s > > [ 15.856244][ T1154] raid6: avx2x1 gen() 13836 MB/s > > [ 15.861474][ T1154] raid6: using algorithm avx512x1 gen() 18155 MB/s > > [ 15.884243][ T1154] raid6: .... xor() 27974 MB/s, rmw enabled > > [ 15.890254][ T1154] raid6: using avx512x2 recovery algorithm > > [ 15.897891][ T1154] xor: measuring software checksum speed > > [ 15.904013][ T1154] prefetch64-sse : 31308 MB/sec > > [ 15.909878][ T1154] generic_sse : 22929 MB/sec > > [ 15.915230][ T1154] xor: using function: prefetch64-sse (31308 MB/sec) > > [ 16.042623][ T1154] Btrfs loaded, zoned=no, fsverity=no > > [ 16.054593][ T930] BTRFS: device fsid e422031c-19be-42f5-ab4f-be5f306aa6e1 devid 1 transid 39725 /dev/sda2 scanned by systemd-udevd (930) > > > > > > then the machine is just stuck there. (whole dmesg captured from serial is > > attached), and the issue is 100% reproducible for this commit. > > > > for parent, we never observed the boot failure. > > > > it looks quite strange to us why this commit could cause this behavior on our > > machine. could you help check dmesg, config and kernel command line which is > > also captured in dmesg, etc. and guide us if anything need to be updated to be > > compatible with this change? Thanks! > > Thanks for the report. With the ctrl and port prefixes dropped, I broke > serial_base_match() looks like. As we attempt to continue anyways, things > still mostly work.. > > Greg, can you please drop the related commit? > > It's the following commit: > > 1ef2c2df1199 ("serial: core: Fix serial core controller port name to show controller id") Please send me a revert, I can't rewrite history in my public branches. thanks, greg k-h