From: Samuel Thibault <samuel.thibault@ens-lyon.org>
To: "Günther Noack" <gnoack3000@gmail.com>
Cc: Kees Cook <keescook@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Randy Dunlap <rdunlap@infradead.org>,
Jiri Slaby <jirislaby@kernel.org>,
Simon Brand <simon.brand@postadigitale.de>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH] TIOCSTI: Document CAP_SYS_ADMIN behaviour in Kconfig
Date: Tue, 8 Aug 2023 22:17:12 +0200 [thread overview]
Message-ID: <20230808201712.efl6vbtsuy57b64d@begin> (raw)
In-Reply-To: <20230808201115.23993-1-gnoack3000@gmail.com>
Günther Noack, le mar. 08 août 2023 22:11:12 +0200, a ecrit:
> Clarifies that the LEGACY_TIOCSTI setting is safe to turn off even
> when running BRLTTY, as it was introduced in commit 690c8b804ad2
> ("TIOCSTI: always enable for CAP_SYS_ADMIN").
>
> Signed-off-by: Günther Noack <gnoack3000@gmail.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> drivers/tty/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tty/Kconfig b/drivers/tty/Kconfig
> index 341abaed4ce..069de553127 100644
> --- a/drivers/tty/Kconfig
> +++ b/drivers/tty/Kconfig
> @@ -164,6 +164,9 @@ config LEGACY_TIOCSTI
> userspace depends on this functionality to continue operating
> normally.
>
> + Processes which run with CAP_SYS_ADMIN, such as BRLTTY, can
> + use TIOCSTI even when this is set to N.
> +
> This functionality can be changed at runtime with the
> dev.tty.legacy_tiocsti sysctl. This configuration option sets
> the default value of the sysctl.
> --
> 2.41.0
>
prev parent reply other threads:[~2023-08-08 20:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 20:11 [PATCH] TIOCSTI: Document CAP_SYS_ADMIN behaviour in Kconfig Günther Noack
2023-08-08 20:17 ` Samuel Thibault [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230808201712.efl6vbtsuy57b64d@begin \
--to=samuel.thibault@ens-lyon.org \
--cc=gnoack3000@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=simon.brand@postadigitale.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).