* [PATCH] TIOCSTI: Document CAP_SYS_ADMIN behaviour in Kconfig
@ 2023-08-08 20:11 Günther Noack
2023-08-08 20:17 ` Samuel Thibault
0 siblings, 1 reply; 2+ messages in thread
From: Günther Noack @ 2023-08-08 20:11 UTC (permalink / raw)
To: Samuel Thibault, Kees Cook
Cc: Günther Noack, Greg Kroah-Hartman, Randy Dunlap, Jiri Slaby,
Simon Brand, linux-kernel, linux-serial
Clarifies that the LEGACY_TIOCSTI setting is safe to turn off even
when running BRLTTY, as it was introduced in commit 690c8b804ad2
("TIOCSTI: always enable for CAP_SYS_ADMIN").
Signed-off-by: Günther Noack <gnoack3000@gmail.com>
---
drivers/tty/Kconfig | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/tty/Kconfig b/drivers/tty/Kconfig
index 341abaed4ce..069de553127 100644
--- a/drivers/tty/Kconfig
+++ b/drivers/tty/Kconfig
@@ -164,6 +164,9 @@ config LEGACY_TIOCSTI
userspace depends on this functionality to continue operating
normally.
+ Processes which run with CAP_SYS_ADMIN, such as BRLTTY, can
+ use TIOCSTI even when this is set to N.
+
This functionality can be changed at runtime with the
dev.tty.legacy_tiocsti sysctl. This configuration option sets
the default value of the sysctl.
--
2.41.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] TIOCSTI: Document CAP_SYS_ADMIN behaviour in Kconfig
2023-08-08 20:11 [PATCH] TIOCSTI: Document CAP_SYS_ADMIN behaviour in Kconfig Günther Noack
@ 2023-08-08 20:17 ` Samuel Thibault
0 siblings, 0 replies; 2+ messages in thread
From: Samuel Thibault @ 2023-08-08 20:17 UTC (permalink / raw)
To: Günther Noack
Cc: Kees Cook, Greg Kroah-Hartman, Randy Dunlap, Jiri Slaby,
Simon Brand, linux-kernel, linux-serial
Günther Noack, le mar. 08 août 2023 22:11:12 +0200, a ecrit:
> Clarifies that the LEGACY_TIOCSTI setting is safe to turn off even
> when running BRLTTY, as it was introduced in commit 690c8b804ad2
> ("TIOCSTI: always enable for CAP_SYS_ADMIN").
>
> Signed-off-by: Günther Noack <gnoack3000@gmail.com>
Reviewed-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> ---
> drivers/tty/Kconfig | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/tty/Kconfig b/drivers/tty/Kconfig
> index 341abaed4ce..069de553127 100644
> --- a/drivers/tty/Kconfig
> +++ b/drivers/tty/Kconfig
> @@ -164,6 +164,9 @@ config LEGACY_TIOCSTI
> userspace depends on this functionality to continue operating
> normally.
>
> + Processes which run with CAP_SYS_ADMIN, such as BRLTTY, can
> + use TIOCSTI even when this is set to N.
> +
> This functionality can be changed at runtime with the
> dev.tty.legacy_tiocsti sysctl. This configuration option sets
> the default value of the sysctl.
> --
> 2.41.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-08-08 20:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-08 20:11 [PATCH] TIOCSTI: Document CAP_SYS_ADMIN behaviour in Kconfig Günther Noack
2023-08-08 20:17 ` Samuel Thibault
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).