linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Jiri Slaby" <jirislaby@kernel.org>,
	"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
	"Andy Shevchenko" <andriy.shevchenko@intel.com>,
	"Dhruva Gole" <d-gole@ti.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"John Ogness" <john.ogness@linutronix.de>,
	"Johan Hovold" <johan@kernel.org>,
	"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	"Guenter Roeck" <groeck7@gmail.com>
Subject: Re: [PATCH] serial: core: Revert port_id use
Date: Wed, 9 Aug 2023 08:37:32 +0300	[thread overview]
Message-ID: <20230809053732.GU14799@atomide.com> (raw)
In-Reply-To: <87dd3019-4eed-1c37-22ad-53ef8e5fcd9e@roeck-us.net>

* Guenter Roeck <linux@roeck-us.net> [230809 05:36]:
> On 8/8/23 22:26, Tony Lindgren wrote:
> > Hi,
> > 
> > * Guenter Roeck <linux@roeck-us.net> [230806 13:19]:
> > > On Sun, Aug 06, 2023 at 09:20:50AM +0300, Tony Lindgren wrote:
> > > > Guenter reports boot issues with duplicate sysfs entries for multiport
> > > > drivers. Let's go back to using port->line for now to fix the regression.
> > > > 
> > > > With this change, the serial core port device names are not correct for the
> > > > hardware specific 8250 single port drivers, but that's a cosmetic issue for
> > > > now.
> > > > 
> > > > Fixes: d962de6ae51f ("serial: core: Fix serial core port id to not use port->line")
> > > > Reported-by: Guenter Roeck <groeck7@gmail.com>
> > > > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > > 
> > > Tested-by: Guenter Roeck <linux@roeck-us.net>
> > 
> > Thanks for testing.
> > 
> > Guenter, care to also test the patch below on top of this fix and
> > see if things still behave for you?
> > 
> 
> Queued. We should have test results sometime tomorrow.

OK great.

Thanks,

Tony

  reply	other threads:[~2023-08-09  5:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-06  6:20 [PATCH] serial: core: Revert port_id use Tony Lindgren
2023-08-06 13:19 ` Guenter Roeck
2023-08-09  5:26   ` Tony Lindgren
2023-08-09  5:33     ` Dhruva Gole
2023-08-09  5:41       ` Tony Lindgren
2023-08-09  5:36     ` Guenter Roeck
2023-08-09  5:37       ` Tony Lindgren [this message]
2023-08-09 21:16     ` Guenter Roeck
2023-08-10  7:00       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230809053732.GU14799@atomide.com \
    --to=tony@atomide.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bigeasy@linutronix.de \
    --cc=d-gole@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=groeck7@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=johan@kernel.org \
    --cc=john.ogness@linutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).