From: Tony Lindgren <tony@atomide.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Dhruva Gole" <d-gole@ti.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Johan Hovold" <johan@kernel.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
"Guenter Roeck" <linux@roeck-us.net>
Subject: Re: [PATCH] serial: core: Fix serial core port id, including multiport devices
Date: Fri, 11 Aug 2023 08:11:21 +0300 [thread overview]
Message-ID: <20230811051121.GL11676@atomide.com> (raw)
In-Reply-To: <ZNUBvZQcbBbCziXU@smile.fi.intel.com>
* Andy Shevchenko <andriy.shevchenko@intel.com> [230810 15:26]:
> On Thu, Aug 10, 2023 at 06:24:13PM +0300, Andy Shevchenko wrote:
> > On Thu, Aug 10, 2023 at 09:57:34AM +0300, Tony Lindgren wrote:
>
> ...
>
> > > + unsigned int min = 0, max = ~0U;
> >
> > Shouldn't this be int? The max IIRC will be INT_MAX with this anyway.
>
> Ah, and then you can supply is as 0 (IIRC).
The returned id will be INT_MAX, but idr.h uses unsigned int:
int ida_alloc_range(struct ida *, unsigned int min, unsigned int max, gfp_t);
If there's some reason to limit max id we can do it, otherwise it's just
a don't care flag.
Please clarify if I'm not following what you are suggesting :)
Regards,
Tony
next prev parent reply other threads:[~2023-08-11 5:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 6:57 [PATCH] serial: core: Fix serial core port id, including multiport devices Tony Lindgren
2023-08-10 8:36 ` Dhruva Gole
2023-08-10 8:49 ` Tony Lindgren
2023-08-10 15:25 ` Andy Shevchenko
2023-08-10 9:09 ` Dhruva Gole
2023-08-10 15:24 ` Andy Shevchenko
2023-08-10 15:26 ` Andy Shevchenko
2023-08-11 5:11 ` Tony Lindgren [this message]
2023-08-11 9:35 ` Andy Shevchenko
2023-08-11 9:35 ` Andy Shevchenko
2023-08-11 9:38 ` Andy Shevchenko
2023-08-11 10:21 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230811051121.GL11676@atomide.com \
--to=tony@atomide.com \
--cc=andriy.shevchenko@intel.com \
--cc=bigeasy@linutronix.de \
--cc=d-gole@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).