From: Greg KH <gregkh@linuxfoundation.org>
To: Dan Raymond <draymond@foxvalley.net>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
linux-serial@vger.kernel.org, ilpo.jarvinen@linux.intel.com
Subject: Re: [PATCH v3] tty/serial: create debugfs interface for UART register tracing
Date: Thu, 31 Aug 2023 20:58:25 +0200 [thread overview]
Message-ID: <2023083101-among-unrented-c0a7@gregkh> (raw)
In-Reply-To: <af06008a-f4d4-1c30-294a-b7af2d4cbc86@foxvalley.net>
On Thu, Aug 31, 2023 at 12:33:33PM -0600, Dan Raymond wrote:
> On 8/31/2023 12:08 PM, Andy Shevchenko wrote:
> > Warning: This email is from an unusual correspondent.
> > Warning: Make sure this is someone you trust.
> >
> > On Thu, Aug 24, 2023 at 02:59:01PM -0600, Dan Raymond wrote:
> >> Implement a UART register tracing facility using the debugfs. This can be
> >> used as a "serial port sniffer" to monitor UART traffic and line settings
> >> with timestamps at microsecond granularity. This can be useful for general
> >> serial port debugging or to debug the UART driver itself.
> >
> >> drivers/tty/serial/8250/8250_debug.c | 530 +++++++++++++++++++++++++++
> >
> > My gosh. Why trace points and trace events can't be used for that?
> >
>
> I don't understand your post. Are you saying there is already a way to
> trace UART register reads/writes without this patch? Can you elaborate?
By adding trace points and trace events, instead of a custom api like
you did. I asked you to look into this already :)
thanks,
greg k-h
next prev parent reply other threads:[~2023-08-31 18:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-24 20:59 [PATCH v3] tty/serial: create debugfs interface for UART register tracing Dan Raymond
2023-08-25 8:06 ` Greg KH
2023-09-13 5:59 ` Dan Raymond
2023-08-31 18:08 ` Andy Shevchenko
2023-08-31 18:33 ` Dan Raymond
2023-08-31 18:58 ` Greg KH [this message]
2023-08-31 22:59 ` Andy Shevchenko
2023-09-11 22:14 ` Dan Raymond
2023-09-11 22:53 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023083101-among-unrented-c0a7@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@intel.com \
--cc=draymond@foxvalley.net \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox