From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7DE81CA0FE1 for ; Fri, 1 Sep 2023 04:47:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232185AbjIAErg (ORCPT ); Fri, 1 Sep 2023 00:47:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232098AbjIAErg (ORCPT ); Fri, 1 Sep 2023 00:47:36 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id B4E75EA for ; Thu, 31 Aug 2023 21:47:32 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 9C75C80BB; Fri, 1 Sep 2023 04:47:31 +0000 (UTC) Date: Fri, 1 Sep 2023 07:47:30 +0300 From: Tony Lindgren To: Matthew Howell Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org, ryan.wenglarz@sealevel.com, james.olson@sealevel.com Subject: Re: [PATCH] serial: Revert serial: core: Fix serial core port id to not use port->line Message-ID: <20230901044730.GL11662@atomide.com> References: <98a891fd-5a1f-6568-a12c-28577126a42@sealevel.com> <20230829035245.GF11662@atomide.com> <511f2dcf-f637-695-8e81-8eaa3735ba88@sealevel.com> <20230829201557.GK11662@atomide.com> <472581f-e7f6-6cc-c749-5be16e4fe9af@sealevel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <472581f-e7f6-6cc-c749-5be16e4fe9af@sealevel.com> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org * Matthew Howell [230831 14:58]: > On Tue, 29 Aug 2023, Tony Lindgren wrote: > > If it is a port_id conflict I'm not sure why commit 3d9e6f556e23 is not > > working for your as it has commit a4a79e03bab5 ("serial: core: Revert > > port_id use"). Care to check that again, or maybe try with v6.5 with just > > the commit below reverted? > > > > 04c7f60ca477 ("serial: core: Fix serial core port id, including multiport devices") > > Just tried that, but no difference. Same error. OK thanks to testing it. So it's starting to look like the issue is somehow related to the serial8250_setup_port() change in commit d962de6ae51f ("serial: core: Fix serial core port id to not use port->line"). The experimental patch below should confirm if the issue is related to the port_id usage or serial8250_setup_port(). Care to give this a try against v6.5 without other patches? > > Dmesg output might help also to figure out if this happens on the first > > port or the second port. > > The full error in dmesg is: > [Aug30 15:48] exar_serial 0000:04:00.0: Couldn't register serial port 0, irq 24, type 2, error -22 > > This is on a 2-port adapter. I don't see any indication in dmesg that it > attempted to register the other port. OK. Are there other 8520 related uarts probing before that? Regards, Tony 8< -------------------- diff --git a/drivers/tty/serial/serial_base_bus.c b/drivers/tty/serial/serial_base_bus.c --- a/drivers/tty/serial/serial_base_bus.c +++ b/drivers/tty/serial/serial_base_bus.c @@ -169,7 +169,7 @@ struct serial_port_device *serial_base_port_add(struct uart_port *port, err = serial_base_device_init(port, &port_dev->dev, &ctrl_dev->dev, &serial_port_type, serial_base_port_release, - port->ctrl_id, port->port_id); + port->ctrl_id, port->line); if (err) goto err_put_device;