* [PATCH] serial: sc16is7xx: remove unused to_sc16is7xx_port macro
@ 2023-09-05 18:16 Hugo Villeneuve
2023-09-06 10:47 ` Ilpo Järvinen
0 siblings, 1 reply; 3+ messages in thread
From: Hugo Villeneuve @ 2023-09-05 18:16 UTC (permalink / raw)
To: Greg Kroah-Hartman, Jiri Slaby
Cc: hugo, Hugo Villeneuve, linux-kernel, linux-serial
From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
This macro is not used anywhere.
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
---
drivers/tty/serial/sc16is7xx.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
index f61d98e09dc3..d8534580c6d5 100644
--- a/drivers/tty/serial/sc16is7xx.c
+++ b/drivers/tty/serial/sc16is7xx.c
@@ -358,7 +358,6 @@ static struct uart_driver sc16is7xx_uart = {
static void sc16is7xx_ier_set(struct uart_port *port, u8 bit);
static void sc16is7xx_stop_tx(struct uart_port *port);
-#define to_sc16is7xx_port(p,e) ((container_of((p), struct sc16is7xx_port, e)))
#define to_sc16is7xx_one(p,e) ((container_of((p), struct sc16is7xx_one, e)))
static int sc16is7xx_line(struct uart_port *port)
base-commit: 3f86ed6ec0b390c033eae7f9c487a3fea268e027
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] serial: sc16is7xx: remove unused to_sc16is7xx_port macro
2023-09-05 18:16 [PATCH] serial: sc16is7xx: remove unused to_sc16is7xx_port macro Hugo Villeneuve
@ 2023-09-06 10:47 ` Ilpo Järvinen
2023-09-06 10:58 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Ilpo Järvinen @ 2023-09-06 10:47 UTC (permalink / raw)
To: Hugo Villeneuve
Cc: Greg Kroah-Hartman, Jiri Slaby, Hugo Villeneuve, LKML,
linux-serial
[-- Attachment #1: Type: text/plain, Size: 1156 bytes --]
On Tue, 5 Sep 2023, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> This macro is not used anywhere.
>
> Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> ---
> drivers/tty/serial/sc16is7xx.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> index f61d98e09dc3..d8534580c6d5 100644
> --- a/drivers/tty/serial/sc16is7xx.c
> +++ b/drivers/tty/serial/sc16is7xx.c
> @@ -358,7 +358,6 @@ static struct uart_driver sc16is7xx_uart = {
> static void sc16is7xx_ier_set(struct uart_port *port, u8 bit);
> static void sc16is7xx_stop_tx(struct uart_port *port);
>
> -#define to_sc16is7xx_port(p,e) ((container_of((p), struct sc16is7xx_port, e)))
> #define to_sc16is7xx_one(p,e) ((container_of((p), struct sc16is7xx_one, e)))
>
> static int sc16is7xx_line(struct uart_port *port)
>
> base-commit: 3f86ed6ec0b390c033eae7f9c487a3fea268e027
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Note that Greg might be happier if you wait next time until after the
merge window is closed before sending non-fixes patch like this.
--
i.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] serial: sc16is7xx: remove unused to_sc16is7xx_port macro
2023-09-06 10:47 ` Ilpo Järvinen
@ 2023-09-06 10:58 ` Greg Kroah-Hartman
0 siblings, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2023-09-06 10:58 UTC (permalink / raw)
To: Ilpo Järvinen
Cc: Hugo Villeneuve, Jiri Slaby, Hugo Villeneuve, LKML, linux-serial
On Wed, Sep 06, 2023 at 01:47:10PM +0300, Ilpo Järvinen wrote:
> On Tue, 5 Sep 2023, Hugo Villeneuve wrote:
>
> > From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> >
> > This macro is not used anywhere.
> >
> > Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
> > ---
> > drivers/tty/serial/sc16is7xx.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c
> > index f61d98e09dc3..d8534580c6d5 100644
> > --- a/drivers/tty/serial/sc16is7xx.c
> > +++ b/drivers/tty/serial/sc16is7xx.c
> > @@ -358,7 +358,6 @@ static struct uart_driver sc16is7xx_uart = {
> > static void sc16is7xx_ier_set(struct uart_port *port, u8 bit);
> > static void sc16is7xx_stop_tx(struct uart_port *port);
> >
> > -#define to_sc16is7xx_port(p,e) ((container_of((p), struct sc16is7xx_port, e)))
> > #define to_sc16is7xx_one(p,e) ((container_of((p), struct sc16is7xx_one, e)))
> >
> > static int sc16is7xx_line(struct uart_port *port)
> >
> > base-commit: 3f86ed6ec0b390c033eae7f9c487a3fea268e027
>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>
> Note that Greg might be happier if you wait next time until after the
> merge window is closed before sending non-fixes patch like this.
I just ignore them and add them to my review queue until after -rc1 is
out, not a problem at all.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-06 10:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-09-05 18:16 [PATCH] serial: sc16is7xx: remove unused to_sc16is7xx_port macro Hugo Villeneuve
2023-09-06 10:47 ` Ilpo Järvinen
2023-09-06 10:58 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox