From: Tony Lindgren <tony@atomide.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Dhruva Gole" <d-gole@ti.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Johan Hovold" <johan@kernel.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Subject: Re: [PATCH v2 3/3] serial: core: Add sysfs links for serial core port instances for ttys
Date: Wed, 13 Sep 2023 15:30:39 +0300 [thread overview]
Message-ID: <20230913123039.GK5285@atomide.com> (raw)
In-Reply-To: <ZQCBAXcFwDqZyBZP@smile.fi.intel.com>
* Andy Shevchenko <andriy.shevchenko@intel.com> [230912 15:17]:
> On Tue, Sep 12, 2023 at 02:03:45PM +0300, Tony Lindgren wrote:
> > + tty_dev = device_find_child(port->dev, &match, serial_match_port);
>
> Can be written as
>
> tty_dev = device_find_child(phys_dev, &match, serial_match_port);
>
> ?
>
> > + if (tty_dev) {
> > + sysfs_remove_link(&port->port_dev->dev.kobj, "tty");
>
> Can be written as
>
> sysfs_remove_link(&port_dev->dev.kobj, "tty");
>
> can't be?
Yes that's shorter.
Thanks,
Tony
prev parent reply other threads:[~2023-09-13 12:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 11:03 [PATCH v2 0/3] Add support for DEVNAME:0.0 style hardware based addressing Tony Lindgren
2023-09-12 11:03 ` [PATCH v2 1/3] printk: Constify name for add_preferred_console() Tony Lindgren
2023-09-20 10:17 ` Petr Mladek
2023-09-20 10:56 ` Ilpo Järvinen
2023-09-28 6:58 ` Tony Lindgren
2023-09-12 11:03 ` [PATCH v2 2/3] serial: core: Add support for DEVNAME:0.0 style naming for kernel console Tony Lindgren
2023-09-12 12:24 ` Ilpo Järvinen
2023-09-13 12:06 ` Tony Lindgren
2023-09-12 15:06 ` Andy Shevchenko
2023-09-13 12:15 ` Tony Lindgren
2023-09-14 5:43 ` Jiri Slaby
2023-09-14 6:07 ` Tony Lindgren
2023-09-12 11:03 ` [PATCH v2 3/3] serial: core: Add sysfs links for serial core port instances for ttys Tony Lindgren
2023-09-12 15:17 ` Andy Shevchenko
2023-09-13 12:30 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230913123039.GK5285@atomide.com \
--to=tony@atomide.com \
--cc=andriy.shevchenko@intel.com \
--cc=bigeasy@linutronix.de \
--cc=d-gole@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).