From: Greg KH <gregkh@linuxfoundation.org>
To: Dan Raymond <draymond@foxvalley.net>
Cc: linux-serial <linux-serial@vger.kernel.org>,
ilpo.jarvinen@linux.intel.com, andriy.shevchenko@intel.com
Subject: Re: [PATCH v4] tty/serial: create debugfs interface for UART register tracing
Date: Mon, 18 Sep 2023 10:15:31 +0200 [thread overview]
Message-ID: <2023091828-cornball-mouse-6b87@gregkh> (raw)
In-Reply-To: <515ad583-5692-d4e0-6fee-cd242dd422b1@foxvalley.net>
On Fri, Sep 15, 2023 at 06:01:35PM -0600, Dan Raymond wrote:
> Implement a UART register tracing facility using the debugfs. This can be
> used as a "serial port sniffer" to monitor UART traffic and line settings
> with timestamps at microsecond granularity. This can be useful for general
> serial port debugging or to debug the UART driver itself.
>
> Signed-off-by: Dan Raymond <draymond@foxvalley.net>
Again, please stick with the tracing infrastructure and use that, like
all other kernel subsystems do. If each driver/subsystem were to create
a tracing interface like this, it would be unmanageable. So unless
there is some really really good reason to not use the trace
infrastructure, this patch can not be accepted.
thanks,
greg k-h
prev parent reply other threads:[~2023-09-18 8:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 0:01 [PATCH v4] tty/serial: create debugfs interface for UART register tracing Dan Raymond
2023-09-16 0:04 ` Dan Raymond
2023-09-18 8:33 ` Andy Shevchenko
2023-09-18 8:15 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023091828-cornball-mouse-6b87@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@intel.com \
--cc=draymond@foxvalley.net \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox