[PATCH V6 1/2] serial: exar: Revert "serial: exar: Add support for Sealevel 7xxxC serial cards"

[PATCH V6 1/2] serial: exar: Revert "serial: exar: Add support for Sealevel 7xxxC serial cards"

[Matthew Howell]

From: Matthew Howell <matthew.howell@sealevel.com>

Hardware ID of Sealevel 7xxxC cards changed prior to release. This has 
rendered 14ee78d5932a redundant.

Revert "serial: exar: Add support for Sealevel 7xxxC serial cards"

This reverts commit 14ee78d5932afeb710c8305196a676a715bfdea8.

Link: https://lore.kernel.org/all/a804d136-4865-f528-6434-68a7358d7606@sealevel.com/T/
Fixes: 14ee78d5932a ("Add support for Sealevel 7xxxC serial cards")
Signed-off-by: Matthew Howell <matthew.howell@sealevel.com>
---
diff --git a/drivers/tty/serial/8250/8250_exar.c b/drivers/tty/serial/8250/8250_exar.c
index 077c3ba3539e..3886f78ecbbf 100644
--- a/drivers/tty/serial/8250/8250_exar.c
+++ b/drivers/tty/serial/8250/8250_exar.c
@@ -47,12 +47,6 @@
 #define PCI_SUBDEVICE_ID_USR_2980		0x0128
 #define PCI_SUBDEVICE_ID_USR_2981		0x0129

-#define PCI_DEVICE_ID_SEALEVEL_710xC		0x1001
-#define PCI_DEVICE_ID_SEALEVEL_720xC		0x1002
-#define PCI_DEVICE_ID_SEALEVEL_740xC		0x1004
-#define PCI_DEVICE_ID_SEALEVEL_780xC		0x1008
-#define PCI_DEVICE_ID_SEALEVEL_716xC		0x1010
-
 #define UART_EXAR_INT0		0x80
 #define UART_EXAR_8XMODE	0x88	/* 8X sampling rate select */
 #define UART_EXAR_SLEEP		0x8b	/* Sleep mode */
@@ -652,8 +646,6 @@ exar_pci_probe(struct pci_dev *pcidev, const struct pci_device_id *ent)
 		nr_ports = BIT(((pcidev->device & 0x38) >> 3) - 1);
 	else if (board->num_ports)
 		nr_ports = board->num_ports;
-	else if (pcidev->vendor == PCI_VENDOR_ID_SEALEVEL)
-		nr_ports = pcidev->device & 0xff;
 	else
 		nr_ports = pcidev->device & 0x0f;

@@ -893,12 +885,6 @@ static const struct pci_device_id exar_pci_tbl[] = {
 	EXAR_DEVICE(COMMTECH, 4224PCI335, pbn_fastcom335_4),
 	EXAR_DEVICE(COMMTECH, 2324PCI335, pbn_fastcom335_4),
 	EXAR_DEVICE(COMMTECH, 2328PCI335, pbn_fastcom335_8),
-
-	EXAR_DEVICE(SEALEVEL, 710xC, pbn_exar_XR17V35x),
-	EXAR_DEVICE(SEALEVEL, 720xC, pbn_exar_XR17V35x),
-	EXAR_DEVICE(SEALEVEL, 740xC, pbn_exar_XR17V35x),
-	EXAR_DEVICE(SEALEVEL, 780xC, pbn_exar_XR17V35x),
-	EXAR_DEVICE(SEALEVEL, 716xC, pbn_exar_XR17V35x),
 	{ 0, }
 };
 MODULE_DEVICE_TABLE(pci, exar_pci_tbl);

Re: [PATCH V6 1/2] serial: exar: Revert "serial: exar: Add support for Sealevel 7xxxC serial cards"

[Greg KH]

On Thu, Sep 14, 2023 at 04:50:32PM -0400, Matthew Howell wrote:
> From: Matthew Howell <matthew.howell@sealevel.com>
> 
> Hardware ID of Sealevel 7xxxC cards changed prior to release. This has 

trailing whitespace :(

> rendered 14ee78d5932a redundant.
> 
> Revert "serial: exar: Add support for Sealevel 7xxxC serial cards"
> 
> This reverts commit 14ee78d5932afeb710c8305196a676a715bfdea8.
> 
> Link: https://lore.kernel.org/all/a804d136-4865-f528-6434-68a7358d7606@sealevel.com/T/

No need for this :(

> Fixes: 14ee78d5932a ("Add support for Sealevel 7xxxC serial cards")

Shouldn't you also cc: stable?

thanks,

greg k-h

Re: [PATCH V6 1/2] serial: exar: Revert "serial: exar: Add support for Sealevel 7xxxC serial cards"

[Matthew Howell]

On Mon, 18 Sep 2023, Greg KH wrote:
> 
> 
> On Thu, Sep 14, 2023 at 04:50:32PM -0400, Matthew Howell wrote:
> > From: Matthew Howell <matthew.howell@sealevel.com>
> >
> > Hardware ID of Sealevel 7xxxC cards changed prior to release. This has
> 
> trailing whitespace :(
> 
> > rendered 14ee78d5932a redundant.
> >
> > Revert "serial: exar: Add support for Sealevel 7xxxC serial cards"
> >
> > This reverts commit 14ee78d5932afeb710c8305196a676a715bfdea8.
> >
> > Link: https://lore.kernel.org/all/a804d136-4865-f528-6434-68a7358d7606@sealevel.com/T/
> 
> No need for this :(
> 
> > Fixes: 14ee78d5932a ("Add support for Sealevel 7xxxC serial cards")
> 
> Shouldn't you also cc: stable?

I can do so in the next submission if that is appropriate. The 
documentation only mentioned cc'ing stable for fixes to 'severe bugs' and 
I didn't think this qualifed.

Also, could you clarify whether you mean just adding the Cc: stable tag, 
or adding the tag AND cc'ing the stable mailing list?
 
> thanks,
> 
> greg k-h
>