linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Edward AD <twuufnxlz@gmail.com>
Cc: eadavis@sina.com, jirislaby@kernel.org,
	linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
	syzbot+b5d1f455d385b2c7da3c@syzkaller.appspotmail.com,
	syzkaller-bugs@googlegroups.com
Subject: Re: [PATCH] tty: fix memory leak in gsm_activate_mux
Date: Tue, 19 Sep 2023 11:31:57 +0200	[thread overview]
Message-ID: <2023091921-duke-gory-866e@gregkh> (raw)
In-Reply-To: <20230919092225.3732786-2-twuufnxlz@gmail.com>

On Tue, Sep 19, 2023 at 05:22:26PM +0800, Edward AD wrote:
> On Tue, 19 Sep 2023 10:29:08 +0200 Greg KH wrote:
> > > When the call to gsm_register_devices() fails, we need to reclaim the memory
> > > requested in gsm_dlci_alloc().
> > >
> > > Fixes: 01aecd917114 ("tty: n_gsm: fix tty registration before control channel open")
> > > Reported-and-tested-by: syzbot+b5d1f455d385b2c7da3c@syzkaller.appspotmail.com
> > > Signed-off-by: Edward AD <twuufnxlz@gmail.com>
> > 
> > Please use your company name/email address, and then just set a manual
> > "From:" line as the first line in the changelog as the documentation
> > asks.  That's how developers work around their broken corporate email
> > systems (but really, you should go and poke your IT group to fix it.)
> This repair was completed in my personal time. Additionally, there may be a 
> possibility of the company's email being thrown away by 'lore.kernel.org'. 
> If you are not very strict with this, I will continue to use my private email.

As you previously submitted this under your company name/address, we
have to be strict for obvious reasons, sorry.

> I will only keep one line starting with 'From:' in the patch.

I don't understand what you mean by this.

greg k-h

  reply	other threads:[~2023-09-19  9:32 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-15  6:29 [syzbot] [serial?] memory leak in gsm_activate_mux syzbot
     [not found] ` <20230915112324.941574-1-eadavis@sina.com>
2023-09-18  8:06   ` [PATCH] tty: fix " Greg KH
     [not found]     ` <20230918084526.2824669-1-eadavis@sina.com>
2023-09-18  9:13       ` Greg KH
     [not found]         ` <20230918104836.2933871-1-eadavis@sina.com>
2023-09-18 12:02           ` Greg KH
     [not found]             ` <20230919034524.3425915-2-eadavis@sina.com>
2023-09-19  7:35               ` Greg KH
2023-09-19  8:02                 ` Edward AD
2023-09-19  8:29                   ` Greg KH
2023-09-19  9:22                     ` Edward AD
2023-09-19  9:31                       ` Greg KH [this message]
2023-09-19  9:55                         ` Edward AD
2023-09-20  6:38                         ` Edward AD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023091921-duke-gory-866e@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=eadavis@sina.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=syzbot+b5d1f455d385b2c7da3c@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=twuufnxlz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).