From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: "Jiri Slaby (SUSE)" <jirislaby@kernel.org>,
linux-serial <linux-serial@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/15] random tty fixes
Date: Tue, 19 Sep 2023 12:21:13 +0200 [thread overview]
Message-ID: <2023091952-civic-balancing-5c50@gregkh> (raw)
In-Reply-To: <6f7b65a8-bc9c-83d2-13c9-a56d85616b53@linux.intel.com>
On Tue, Sep 19, 2023 at 01:17:49PM +0300, Ilpo Järvinen wrote:
> On Tue, 19 Sep 2023, Jiri Slaby (SUSE) wrote:
>
> > This is a collection of random fixes for tty I did while crawling
> > through the code. Mostly done for readability and understandability. No
> > behavior change intended (except for Documentation fixes).
> >
> > Jiri Slaby (SUSE) (15):
> > tty: n_tty: use 'retval' instead of 'c'
> > tty: n_tty: rename and retype 'retval' in n_tty_ioctl()
> > tty: n_tty: use min3() in copy_from_read_buf()
> > tty: n_tty: invert the condition in copy_from_read_buf()
> > tty: n_tty: use do-while in n_tty_check_{,un}throttle()
> > tty: switch tty_{,un}throttle_safe() to return a bool
> > tty: invert return values of tty_{,un}throttle_safe()
> > tty: fix up and plug in tty_ioctl kernel-doc
> > tty: fix kernel-doc for functions in tty.h
> > tty: stop using ndash in kernel-doc
> > tty: tty_buffer: use bool for 'restart' in
> > tty_buffer_unlock_exclusive()
> > tty: convert THROTTLE constants into enum
> > tty: early return from send_break() on TTY_DRIVER_HARDWARE_BREAK
> > tty: don't check for signal_pending() in send_break()
> > tty: use 'if' in send_break() instead of 'goto'
> >
> > Documentation/driver-api/tty/index.rst | 1 +
> > Documentation/driver-api/tty/tty_ioctl.rst | 10 +
> > drivers/tty/n_tty.c | 77 ++++---
> > drivers/tty/tty.h | 13 +-
> > drivers/tty/tty_buffer.c | 5 +-
> > drivers/tty/tty_io.c | 36 ++--
> > drivers/tty/tty_ioctl.c | 234 ++++++++++-----------
> > drivers/tty/tty_port.c | 6 +-
> > drivers/tty/vt/consolemap.c | 2 +-
> > drivers/tty/vt/vc_screen.c | 4 +-
> > drivers/tty/vt/vt.c | 4 +-
> > include/linux/tty.h | 25 +--
> > 12 files changed, 209 insertions(+), 208 deletions(-)
> > create mode 100644 Documentation/driver-api/tty/tty_ioctl.rst
>
> For this whole series except the patches I commented on:
>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
>
> ...If you make the amendments I requested, please add the tag also to the
> patches I commented on.
That's horrible, b4 will now just add this reviewed-by to all of them
when I run it :(
greg k-h
next prev parent reply other threads:[~2023-09-19 10:21 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-19 8:51 [PATCH 00/15] random tty fixes Jiri Slaby (SUSE)
2023-09-19 8:51 ` [PATCH 01/15] tty: n_tty: use 'retval' instead of 'c' Jiri Slaby (SUSE)
2023-09-19 8:51 ` [PATCH 02/15] tty: n_tty: rename and retype 'retval' in n_tty_ioctl() Jiri Slaby (SUSE)
2023-09-19 8:51 ` [PATCH 03/15] tty: n_tty: use min3() in copy_from_read_buf() Jiri Slaby (SUSE)
2023-09-19 8:51 ` [PATCH 04/15] tty: n_tty: invert the condition " Jiri Slaby (SUSE)
2023-09-19 9:54 ` Ilpo Järvinen
2023-09-19 10:43 ` Jiri Slaby
2023-09-19 8:51 ` [PATCH 05/15] tty: n_tty: use do-while in n_tty_check_{,un}throttle() Jiri Slaby (SUSE)
2023-09-19 8:51 ` [PATCH 06/15] tty: switch tty_{,un}throttle_safe() to return a bool Jiri Slaby (SUSE)
2023-09-19 8:51 ` [PATCH 07/15] tty: invert return values of tty_{,un}throttle_safe() Jiri Slaby (SUSE)
2023-09-19 8:51 ` [PATCH 08/15] tty: fix up and plug in tty_ioctl kernel-doc Jiri Slaby (SUSE)
2023-09-19 8:51 ` [PATCH 09/15] tty: fix kernel-doc for functions in tty.h Jiri Slaby (SUSE)
2023-09-19 10:07 ` Ilpo Järvinen
2023-09-19 10:45 ` Jiri Slaby
2023-09-19 10:47 ` Jiri Slaby
2023-09-19 10:51 ` Ilpo Järvinen
2023-09-19 8:51 ` [PATCH 10/15] tty: stop using ndash in kernel-doc Jiri Slaby (SUSE)
2023-09-19 8:51 ` [PATCH 11/15] tty: tty_buffer: use bool for 'restart' in tty_buffer_unlock_exclusive() Jiri Slaby (SUSE)
2023-09-19 8:51 ` [PATCH 12/15] tty: convert THROTTLE constants into enum Jiri Slaby (SUSE)
2023-09-19 10:10 ` Ilpo Järvinen
2023-09-19 10:51 ` Jiri Slaby
2023-09-19 8:51 ` [PATCH 13/15] tty: early return from send_break() on TTY_DRIVER_HARDWARE_BREAK Jiri Slaby (SUSE)
2023-09-19 8:51 ` [PATCH 14/15] tty: don't check for signal_pending() in send_break() Jiri Slaby (SUSE)
2023-09-19 10:14 ` Ilpo Järvinen
2023-09-19 8:51 ` [PATCH 15/15] tty: use 'if' in send_break() instead of 'goto' Jiri Slaby (SUSE)
2023-09-19 10:17 ` [PATCH 00/15] random tty fixes Ilpo Järvinen
2023-09-19 10:21 ` Greg Kroah-Hartman [this message]
2023-09-19 10:53 ` Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023091952-civic-balancing-5c50@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).