linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Phillip Potter <phil@philpotter.co.uk>
To: devnull+j.granados.samsung.com@kernel.org
Cc: Jason@zx2c4.com, airlied@gmail.com, arnd@arndb.de,
	clemens@ladisch.de, daniel@ffwll.ch, davem@davemloft.net,
	decui@microsoft.com, dgilbert@interlog.com,
	dri-devel@lists.freedesktop.org, dsahern@kernel.org,
	edumazet@google.com, gregkh@linuxfoundation.org,
	haiyangz@microsoft.com, intel-gfx@lists.freedesktop.org,
	j.granados@samsung.com, jani.nikula@linux.intel.com,
	jejb@linux.ibm.com, jgg@ziepe.ca, jgross@suse.com,
	jirislaby@kernel.org, joonas.lahtinen@linux.intel.com,
	josh@joshtriplett.org, keescook@chromium.org, kuba@kernel.org,
	kys@microsoft.com, leon@kernel.org, linux-hyperv@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-raid@vger.kernel.org,
	linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	martin.petersen@oracle.com, mcgrof@kernel.org, minyard@acm.org,
	netdev@vger.kernel.org, oleksandr_tyshchenko@epam.com,
	openipmi-developer@lists.sourceforge.net, pabeni@redhat.com,
	phil@philpotter.co.uk, rafael@kernel.org, robinmholt@gmail.com,
	rodrigo.vivi@intel.com, russell.h.weight@intel.com,
	song@kernel.org, sstabellini@kernel.org, steve.wahl@hpe.com,
	sudipm.mukherjee@gmail.com, tvrtko.ursulin@linux.intel.com,
	tytso@mit.edu, wei.liu@kernel.org, willy@infradead.org,
	xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array
Date: Mon,  2 Oct 2023 22:45:28 +0100	[thread overview]
Message-ID: <20231002214528.15529-1-phil@philpotter.co.uk> (raw)
In-Reply-To: <20231002-jag-sysctl_remove_empty_elem_drivers-v2-1-02dd0d46f71e@samsung.com>

> From: Joel Granados <j.granados@samsung.com>
>
> This commit comes at the tail end of a greater effort to remove the
> empty elements at the end of the ctl_table arrays (sentinels) which
> will reduce the overall build time size of the kernel and run time
> memory bloat by ~64 bytes per sentinel (further information Link :
> https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)
>
> Remove sentinel element from cdrom_table
>
> Signed-off-by: Joel Granados <j.granados@samsung.com>
> ---
>  drivers/cdrom/cdrom.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/cdrom/cdrom.c b/drivers/cdrom/cdrom.c
> index cc2839805983..a5e07270e0d4 100644
> --- a/drivers/cdrom/cdrom.c
> +++ b/drivers/cdrom/cdrom.c
> @@ -3655,7 +3655,6 @@ static struct ctl_table cdrom_table[] = {
>  		.mode		= 0644,
>  		.proc_handler	= cdrom_sysctl_handler
>  	},
> -	{ }
>  };
>  static struct ctl_table_header *cdrom_sysctl_header;
>
>
> -- 
> 2.30.2


Hi Joel,

Looks good to me, many thanks. I'll send on for inclusion.

Reviewed-by: Phillip Potter <phil@philpotter.co.uk>

Regards,
Phil

  reply	other threads:[~2023-10-02 21:45 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-02  8:55 [PATCH v2 00/15] sysctl: Remove sentinel elements from drivers Joel Granados via B4 Relay
2023-10-02  8:55 ` [PATCH v2 01/15] cdrom: Remove now superfluous sentinel element from ctl_table array Joel Granados via B4 Relay
2023-10-02 21:45   ` Phillip Potter [this message]
2023-10-02  8:55 ` [PATCH v2 02/15] hpet: " Joel Granados via B4 Relay
2023-10-02  8:55 ` [PATCH v2 03/15] xen: " Joel Granados via B4 Relay
2023-10-02  8:55 ` [PATCH v2 04/15] tty: " Joel Granados via B4 Relay
2023-10-02  8:58   ` Jiri Slaby
2023-10-02  8:55 ` [PATCH v2 05/15] scsi: " Joel Granados via B4 Relay
2023-10-02  8:55 ` [PATCH v2 06/15] parport: Remove the " Joel Granados via B4 Relay
2023-10-02  8:55 ` [PATCH v2 07/15] macintosh: " Joel Granados via B4 Relay
2023-10-02  8:55 ` [PATCH v2 08/15] infiniband: " Joel Granados via B4 Relay
2023-10-02  8:55 ` [PATCH v2 09/15] char-misc: " Joel Granados via B4 Relay
2023-10-02 12:27 ` [PATCH v2 00/15] sysctl: Remove sentinel elements from drivers Christophe Leroy
2023-10-03  8:47   ` Joel Granados
     [not found] ` <651a84ff.050a0220.51ca9.2e91SMTPIN_ADDED_BROKEN@mx.google.com>
2023-10-02 14:17   ` [PATCH v2 10/15] vrf: Remove the now superfluous sentinel element from ctl_table array David Ahern
     [not found] ` <=?utf-8?q?=3C20231002-jag-sysctl=5Fremove=5Fempty=5Felem=5Fdrive?=>
2023-10-02 14:33   ` [PATCH v2 11/15] sgi-xp: " Steve Wahl
2023-10-10 22:26 ` [PATCH v2 00/15] sysctl: Remove sentinel elements from drivers Luis Chamberlain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231002214528.15529-1-phil@philpotter.co.uk \
    --to=phil@philpotter.co.uk \
    --cc=Jason@zx2c4.com \
    --cc=airlied@gmail.com \
    --cc=arnd@arndb.de \
    --cc=clemens@ladisch.de \
    --cc=daniel@ffwll.ch \
    --cc=davem@davemloft.net \
    --cc=decui@microsoft.com \
    --cc=devnull+j.granados.samsung.com@kernel.org \
    --cc=dgilbert@interlog.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=haiyangz@microsoft.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=j.granados@samsung.com \
    --cc=jani.nikula@linux.intel.com \
    --cc=jejb@linux.ibm.com \
    --cc=jgg@ziepe.ca \
    --cc=jgross@suse.com \
    --cc=jirislaby@kernel.org \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=josh@joshtriplett.org \
    --cc=keescook@chromium.org \
    --cc=kuba@kernel.org \
    --cc=kys@microsoft.com \
    --cc=leon@kernel.org \
    --cc=linux-hyperv@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-raid@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=martin.petersen@oracle.com \
    --cc=mcgrof@kernel.org \
    --cc=minyard@acm.org \
    --cc=netdev@vger.kernel.org \
    --cc=oleksandr_tyshchenko@epam.com \
    --cc=openipmi-developer@lists.sourceforge.net \
    --cc=pabeni@redhat.com \
    --cc=rafael@kernel.org \
    --cc=robinmholt@gmail.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=russell.h.weight@intel.com \
    --cc=song@kernel.org \
    --cc=sstabellini@kernel.org \
    --cc=steve.wahl@hpe.com \
    --cc=sudipm.mukherjee@gmail.com \
    --cc=tvrtko.ursulin@linux.intel.com \
    --cc=tytso@mit.edu \
    --cc=wei.liu@kernel.org \
    --cc=willy@infradead.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).