From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 355A6E8FDDB for ; Wed, 4 Oct 2023 09:03:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232855AbjJDJD0 (ORCPT ); Wed, 4 Oct 2023 05:03:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35460 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232554AbjJDJD0 (ORCPT ); Wed, 4 Oct 2023 05:03:26 -0400 Received: from muru.com (muru.com [72.249.23.125]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 7F00498; Wed, 4 Oct 2023 02:03:22 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id DFFFE80BD; Wed, 4 Oct 2023 09:03:21 +0000 (UTC) Date: Wed, 4 Oct 2023 12:03:20 +0300 From: Tony Lindgren To: Johan Hovold Cc: Maximilian Luz , Greg Kroah-Hartman , Jiri Slaby , Andy Shevchenko , Dhruva Gole , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , John Ogness , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-omap@vger.kernel.org, Andy Shevchenko , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v12 1/1] serial: core: Start managing serial controllers to enable runtime PM Message-ID: <20231004090320.GE34982@atomide.com> References: <20230525113034.46880-1-tony@atomide.com> <62d3678a-a23d-4619-95de-145026629ba8@gmail.com> <20231003121455.GB34982@atomide.com> <20231003122137.GC34982@atomide.com> <20231004061708.GD34982@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org * Johan Hovold [231004 07:14]: > The pm_runtime_get_sync() in serdev_device_open() is supposed to prevent > that from happening by default and if that now longer works, then that > needs to be fixed. No changes there, that all should work just as before. What is broken is that the new serial port device can autosuspend while the serdev device is active. This prevents serial tx in the suspend path. The serial port device and serdev device are siblings of the physical serial port controller device as seen in the hierarcy printed out by Maximilian. Regards, Tony