From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3B6BFE92711 for ; Thu, 5 Oct 2023 15:36:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233913AbjJEPgJ (ORCPT ); Thu, 5 Oct 2023 11:36:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50520 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229766AbjJEPfa (ORCPT ); Thu, 5 Oct 2023 11:35:30 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FAED5C68B; Thu, 5 Oct 2023 07:50:49 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0E445C433BD; Thu, 5 Oct 2023 07:38:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696491510; bh=IlcFL0Ucixl4pYJLprQCCNUw2SjWVzzJQeaMUDlMx0E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OaIkL6A4CYjNbyQebbP6Yd0cnVsPIaK6QAG8faOg4JEacU7res4MGn61zx0ouZHxN orkn8binUoDtP7EGuwK0XyQqSLgY5L7GYU7K6XNfXPshLf+V5ljzOLt0J2Vf8DDXzd KLs1g8EvEmpWVwl6ZZ294xQYKQQotykzAPPGBJs8= Date: Thu, 5 Oct 2023 09:38:27 +0200 From: Greg KH To: Florian Eckert Cc: Jiri Slaby , Lee Jones , Eckert.Florian@googlemail.com, pavel@ucw.cz, kabel@kernel.org, u.kleine-koenig@pengutronix.de, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-leds@vger.kernel.org, kernel test robot Subject: Re: [PATCH v2 3/4] trigger: ledtrig-tty: move variable definition to the top Message-ID: <2023100508-prelaunch-marbled-3a93@gregkh> References: <20230928132632.200263-1-fe@dev.tdt.de> <20230928132632.200263-4-fe@dev.tdt.de> <20231002140559.GB8453@google.com> <59cc4073a94edbdec5d77f8457ed4f73@dev.tdt.de> <05b03f3e-5863-4d33-8c70-03be7d7e972f@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Wed, Oct 04, 2023 at 10:36:09AM +0200, Florian Eckert wrote: > > > > > I decided to move the variable definition with a separate commit > > > to the top of the function, to make the build robot happy. After that > > > I made my changes for v2 to the ledtrig-tty to add the feature. > > > > > > > Ah, lkp, then also the Closes: line as it suggests. > > > > > > Sorry I do not understand your statement > > > > The link you pasted above states: > > ======= > > If you fix the issue in a separate patch/commit (i.e. not just a new > > version of > > the same patch/commit), kindly add following tags > > | Reported-by: kernel test robot > > | Closes: > > https://lore.kernel.org/oe-kbuild-all/202309270440.IJB24Xap-lkp@intel.com/ > > ======= > > > > So please follow that suggestion ;). > > Ok, I understand, thanks will to this on a v3 patchset. > I will now wait for the comments of my changes in ledtrig-tty from the led > subsystem. > And then I will send a new patch set with the requested changes. > > Sorry for the silly question. But do I have to send this patch again for a > v3? > https://lore.kernel.org/linux-leds/f41dc1e1-6d34-48b2-97dd-ba67df6003c6@kernel.org/T/#u > It was already marked by you with a `Reviewed-by:` from you? This series is long gone from my review queue, so a v3 will be needed at the very least. thanks, greg k-h