From: Max Filippov <jcmvbkbc@gmail.com>
To: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Max Filippov <jcmvbkbc@gmail.com>
Subject: [PATCH] serial: add PORT_ANY definition
Date: Fri, 6 Oct 2023 04:57:13 -0700 [thread overview]
Message-ID: <20231006115713.801322-1-jcmvbkbc@gmail.com> (raw)
Current pattern in the linux kernel is that every new serial driver adds
one or more new PORT_ definitions because uart_ops::config_port()
callback documentation prescribes setting port->type according to the
type of port found, or to PORT_UNKNOWN if no port was detected.
When the specific type of the port is not important to the userspace
there's no need for a unique PORT_ value, but so far there's no suitable
identifier for that case.
Provide generic port type identifier other than PORT_UNKNOWN for ports
which type is not important to userspace.
Suggested-by: Arnd Bergmann <arnd@arndb.de>
Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---
include/uapi/linux/serial.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/uapi/linux/serial.h b/include/uapi/linux/serial.h
index 53bc1af67a41..070e50cf9e1e 100644
--- a/include/uapi/linux/serial.h
+++ b/include/uapi/linux/serial.h
@@ -47,6 +47,8 @@ struct serial_struct {
/*
* These are the supported serial types.
*/
+/* Generic type identifier for ports which type is not important to userspace. */
+#define PORT_ANY (-1)
#define PORT_UNKNOWN 0
#define PORT_8250 1
#define PORT_16450 2
--
2.30.2
next reply other threads:[~2023-10-06 11:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 11:57 Max Filippov [this message]
2023-10-07 9:17 ` [PATCH] serial: add PORT_ANY definition Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231006115713.801322-1-jcmvbkbc@gmail.com \
--to=jcmvbkbc@gmail.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).