From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Max Filippov <jcmvbkbc@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
devicetree@vger.kernel.org, "Jiri Slaby" <jirislaby@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v4 5/5] drivers/tty/serial: add ESP32S3 ACM device driver
Date: Fri, 6 Oct 2023 13:04:32 +0200 [thread overview]
Message-ID: <2023100640-isolating-privatize-7bf7@gregkh> (raw)
In-Reply-To: <CAMo8BfLfBEQVTyBXw=K2wsgGF+ZUfJhffX4ax8kX+k_DPSOKYg@mail.gmail.com>
On Fri, Oct 06, 2023 at 03:27:37AM -0700, Max Filippov wrote:
> On Fri, Oct 6, 2023 at 2:34 AM Greg Kroah-Hartman
> > > > Yes, but not all do. If you don't need to do anything special, it can
> > > > just claim to be a normal device, we've had threads about this on the
> > > > list before. If you don't need to determine in userspace from the tty
> > > > connection what device it is, just use the default one instead.
> > >
> > > Ok, it looks like having
> > >
> > > #define PORT_ESP32ACM (-1)
> > >
> > > in the driver source should be ok? I've tested that it works.
> >
> > Hah, I like that hack. But why not just use PORT_UNKNOWN?
>
> A lot of functionality doesn't work with PORT_UNKNOWN, e.g.
> console or modem control.
> I've got the idea of using -1 from this email:
> https://lore.kernel.org/linux-serial/502240f7-2cac-4fe6-9e27-f9861db3666d@app.fastmail.com/
Ok, we should encode this as a "real" number, "PORT_ANY" and set it to
-1 and let all new devices use it.
thanks,
greg k-h
next prev parent reply other threads:[~2023-10-06 11:04 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 15:16 [PATCH v4 0/5] serial: add drivers for the ESP32xx serial devices Max Filippov
2023-09-28 15:16 ` [PATCH v4 1/5] serial: core: tidy invalid baudrate handling in uart_get_baud_rate Max Filippov
2023-09-29 6:34 ` Ilpo Järvinen
2023-09-29 19:26 ` Max Filippov
2023-10-03 12:39 ` Greg Kroah-Hartman
2023-09-28 15:16 ` [PATCH v4 2/5] dt-bindings: serial: document esp32-uart Max Filippov
2023-09-28 15:16 ` [PATCH v4 3/5] drivers/tty/serial: add driver for the ESP32 UART Max Filippov
2023-10-03 12:56 ` Greg Kroah-Hartman
2023-09-28 15:16 ` [PATCH v4 4/5] dt-bindings: serial: document esp32s3-acm Max Filippov
2023-09-28 15:16 ` [PATCH v4 5/5] drivers/tty/serial: add ESP32S3 ACM device driver Max Filippov
2023-10-03 12:55 ` Greg Kroah-Hartman
2023-10-03 19:46 ` Max Filippov
2023-10-05 18:57 ` Greg Kroah-Hartman
2023-10-05 21:21 ` Max Filippov
2023-10-06 9:34 ` Greg Kroah-Hartman
2023-10-06 10:27 ` Max Filippov
2023-10-06 11:04 ` Greg Kroah-Hartman [this message]
2023-10-06 14:11 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023100640-isolating-privatize-7bf7@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jcmvbkbc@gmail.com \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).