From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7049ECD611D for ; Mon, 9 Oct 2023 17:32:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377437AbjJIRcE (ORCPT ); Mon, 9 Oct 2023 13:32:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37684 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376824AbjJIRcC (ORCPT ); Mon, 9 Oct 2023 13:32:02 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9869F94; Mon, 9 Oct 2023 10:32:00 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E99C5C433C7; Mon, 9 Oct 2023 17:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1696872720; bh=XDeMdfLHaRv+b+MlRUUeKv/nia38YeOU/WDZx5uPdgo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=n7htfkkYUR12EIz1FfiE1jX2eFvUEHVFPryxLjmFbPuCO63JBXFgzZFBrFSr8POoM nOqBt8Ex9K985cGV6+qhK/D41SCIeSdiXbcUvI9IgH95SuKRTpkX2tFZxU1fggV/Co h4FDmqr5W2gDoU8y1iBRT+VGpOLpUw9MzF+NINbA= Date: Mon, 9 Oct 2023 19:31:56 +0200 From: Greg Kroah-Hartman To: Max Kellermann Cc: Jens Axboe , "Rafael J. Wysocki" , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter , Jean Delvare , Guenter Roeck , Jason Gunthorpe , Leon Romanovsky , Bart Van Assche , Joerg Roedel , Will Deacon , Robin Murphy , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Keith Busch , Christoph Hellwig , Sagi Grimberg , Alessandro Zummo , Alexandre Belloni , Jiri Slaby , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Thomas Gleixner , Peter Zijlstra , Pavel Machek , Lee Jones , Arnd Bergmann , Bjorn Helgaas , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Sebastian Reichel , Krzysztof Kozlowski , Wim Van Sebroeck , "James E.J. Bottomley" , "Martin K. Petersen" , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-leds@vger.kernel.org, linux-pci@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 6/7] fs/sysfs/group: make attribute_group pointers const Message-ID: <2023100944-fancied-garter-f09b@gregkh> References: <20231009165741.746184-1-max.kellermann@ionos.com> <20231009165741.746184-6-max.kellermann@ionos.com> <2023100921-that-jasmine-2240@gregkh> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2023100921-that-jasmine-2240@gregkh> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Mon, Oct 09, 2023 at 07:25:57PM +0200, Greg Kroah-Hartman wrote: > On Mon, Oct 09, 2023 at 06:57:39PM +0200, Max Kellermann wrote: > > This allows passing arrays of const pointers. The goal is to make > > lots of global variables "const" to allow them to live in the > > ".rodata" section. > > I'm all for doing this type of work, but this is going to be rough. You > sent patch 6/7 that hit almost all subsystems at once :( The way to do this right is one-subsystem-at-a-time, right? Why not start there, doing it cleanly, and then at the end, change the driver core and then just the subsystem pointers? That should be much simpler, easier to review and verify, and many more changes (and probably take a kernel release or two to get through.) thanks, greg k-h