Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
To: gregkh@linuxfoundation.org, jirislaby@kernel.org,
	ilpo.jarvinen@linux.intel.com
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de,
	mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com,
	cniedermaier@dh-electronics.com, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org, LinoSanfilippo@gmx.de,
	lukas@wunner.de, p.rosenberger@kunbus.com,
	Lino Sanfilippo <l.sanfilippo@kunbus.com>,
	stable@vger.kernel.org
Subject: [PATCH v3 6/6] serial: omap: do not override settings for RS485 support
Date: Wed, 11 Oct 2023 20:15:44 +0200	[thread overview]
Message-ID: <20231011181544.7893-7-l.sanfilippo@kunbus.com> (raw)
In-Reply-To: <20231011181544.7893-1-l.sanfilippo@kunbus.com>

In serial_omap_rs485() RS485 support may be deactivated due to a missing
RTS GPIO. This is done by nullifying the ports rs485_supported struct.
After that however the serial_omap_rs485_supported struct is assigned to
the same structure unconditionally, which results in an unintended
reactivation of RS485 support.
Fix this by callling serial_omap_rs485() after the assignment of
rs485_supported.

Fixes: e2752ae3cfc9 ("serial: omap: Disallow RS-485 if rts-gpio is not specified")
Cc: stable@vger.kernel.org
Signed-off-by: Lino Sanfilippo <l.sanfilippo@kunbus.com>
---
 drivers/tty/serial/omap-serial.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/tty/serial/omap-serial.c b/drivers/tty/serial/omap-serial.c
index 0ead88c5a19a..4f7ee4392034 100644
--- a/drivers/tty/serial/omap-serial.c
+++ b/drivers/tty/serial/omap-serial.c
@@ -1604,10 +1604,6 @@ static int serial_omap_probe(struct platform_device *pdev)
 		dev_info(up->port.dev, "no wakeirq for uart%d\n",
 			 up->port.line);
 
-	ret = serial_omap_probe_rs485(up, &pdev->dev);
-	if (ret < 0)
-		goto err_rs485;
-
 	sprintf(up->name, "OMAP UART%d", up->port.line);
 	up->port.mapbase = mem->start;
 	up->port.membase = base;
@@ -1622,6 +1618,10 @@ static int serial_omap_probe(struct platform_device *pdev)
 			 DEFAULT_CLK_SPEED);
 	}
 
+	ret = serial_omap_probe_rs485(up, &pdev->dev);
+	if (ret < 0)
+		goto err_rs485;
+
 	up->latency = PM_QOS_CPU_LATENCY_DEFAULT_VALUE;
 	up->calc_latency = PM_QOS_CPU_LATENCY_DEFAULT_VALUE;
 	cpu_latency_qos_add_request(&up->pm_qos_request, up->latency);
-- 
2.40.1


  parent reply	other threads:[~2023-10-11 18:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11 18:15 [PATCH v3 0/6] Fixes and improvements for RS485 Lino Sanfilippo
2023-10-11 18:15 ` [PATCH v3 1/6] serial: Do not hold the port lock when setting rx-during-tx GPIO Lino Sanfilippo
2023-10-11 22:36   ` Hugo Villeneuve
2023-10-12 11:17     ` Lino Sanfilippo
2023-10-11 18:15 ` [PATCH v3 2/6] serial: core: set missing supported flag for RX during TX GPIO Lino Sanfilippo
2023-10-11 18:15 ` [PATCH v3 3/6] serial: core: fix sanitizing check for RTS settings Lino Sanfilippo
2023-10-12 13:10   ` Ilpo Järvinen
2023-10-12 21:01     ` Lino Sanfilippo
2023-10-13 10:24       ` Ilpo Järvinen
2023-10-14 12:23         ` Lino Sanfilippo
2023-10-16 10:05           ` Ilpo Järvinen
2023-10-16 10:10             ` Lino Sanfilippo
2023-10-11 18:15 ` [PATCH v3 4/6] serial: core: make sure RS485 cannot be enabled when it is not supported Lino Sanfilippo
2023-10-11 18:15 ` [PATCH v3 5/6] serial: core, imx: do not set RS485 enabled if " Lino Sanfilippo
2023-10-11 18:15 ` Lino Sanfilippo [this message]
2023-10-15 13:03 ` [PATCH v3 0/6] Fixes and improvements for RS485 Lino Sanfilippo
2023-10-16 10:38   ` Uwe Kleine-König
2023-10-16 10:45     ` Lino Sanfilippo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231011181544.7893-7-l.sanfilippo@kunbus.com \
    --to=l.sanfilippo@kunbus.com \
    --cc=LinoSanfilippo@gmx.de \
    --cc=alexandre.torgue@foss.st.com \
    --cc=cniedermaier@dh-electronics.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=p.rosenberger@kunbus.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox