linux-serial.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Dan Raymond <raymod2@gmail.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
	linux-serial <linux-serial@vger.kernel.org>,
	tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
	dave.hansen@linux.intel.com, hpa@zytor.com, peterz@infradead.org,
	andriy.shevchenko@linux.intel.com, quic_saipraka@quicinc.com,
	Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH v5] arch/x86: port I/O tracing on x86
Date: Wed, 11 Oct 2023 22:41:08 +0200	[thread overview]
Message-ID: <2023101129-dragonish-chaplain-ab30@gregkh> (raw)
In-Reply-To: <e92f5091-4e50-9241-5b60-39be101e70d6@gmail.com>

On Wed, Oct 11, 2023 at 02:22:14PM -0600, Dan Raymond wrote:
> On 10/7/2023 11:56 AM, Dan Raymond wrote:
> > Add support for port I/O tracing on x86.  Memory mapped I/O tracing is
> > available on x86 via CONFIG_MMIOTRACE but that relies on page faults
> > so it doesn't work with port I/O.  This feature uses tracepoints in a
> > similar manner as CONFIG_TRACE_MMIO_ACCESS.
> > 
> > Signed-off-by: Dan Raymond <raymod2@gmail.com>
> > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > V1 -> V2:
> >   - create header file for prototypes to silence new compiler warning
> >   - reduce CPU overhead to 2 instructions (no branching) when tracing disabled
> >   - fix imprecise IP logging by retrieving the IP off the stack instead of using
> >     compile time labels
> > 
> > V2 -> V3:
> >   - restore missing semicolon
> > 
> > V3 -> V4:
> >   - make GPL licenses consistent
> >   - change pointer arguments from (long) to (void *)
> >   - eliminate include guard checks and use -DDISABLE_TRACEPOINTS instead to
> >     disable tracepoints in arch/x86/boot/*
> >   - fix compiler warnings due to signed/unsigned mismatch in arch_cmpxchg64()
> > 
> > V4 -> V5:
> >   - add -DDISABLE_TRACEPOINTS to arch/x86/realmode/rm/Makefile
> 
> Can I get reviews on this please?

You sent it 3 days ago, please be patient, there is no need to demand
work from others so quickly, most of us are totally swamped.  If after 2
weeks or so with no review, then you can ask again.

In the meantime, to help us out, please do some patch review yourself on
the various mailing lists (the tty list can always use help.)  To ask
for work from others without helping out is not always good...

thanks,

greg k-h

  reply	other threads:[~2023-10-11 20:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-29 19:15 [PATCH v3] arch/x86: port I/O tracing on x86 Dan Raymond
2023-10-03 12:50 ` Greg KH
2023-10-04 22:54   ` Dan Raymond
2023-10-04 23:50     ` Steven Rostedt
2023-10-06 21:29       ` Dan Raymond
2023-10-06 21:32       ` [PATCH v4] " Dan Raymond
2023-10-07  6:53         ` kernel test robot
2023-10-07 17:56         ` [PATCH v5] " Dan Raymond
2023-10-11 20:22           ` Dan Raymond
2023-10-11 20:41             ` Greg KH [this message]
2023-10-21 16:00           ` Greg KH
2023-10-21 20:15             ` Steven Rostedt
2023-10-23 21:29               ` Dan Raymond
2023-10-23 21:51                 ` Steven Rostedt
2023-10-23 20:28             ` Dan Raymond
2023-10-24  9:32               ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023101129-dragonish-chaplain-ab30@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=quic_saipraka@quicinc.com \
    --cc=raymod2@gmail.com \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).