Re: [tty:tty-testing 12/24] drivers/tty/serial/8250/8250_ni.c:446:41: warning: 'nic7a69' defined but not used

[Greg Kroah-Hartman <gregkh@linuxfoundation.org>]

On Tue, Oct 17, 2023 at 04:37:14AM +0800, kernel test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
> head:   d7b7027a2dcfb08e3e592c81978551f53c3beb4f
> commit: 59dbecf92fa66c454ba8011231212e3ca51aae28 [12/24] serial: 8250: add driver for NI UARTs
> config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231017/202310170418.GCOnw1n1-lkp@intel.com/config)
> compiler: m68k-linux-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231017/202310170418.GCOnw1n1-lkp@intel.com/reproduce)
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@intel.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202310170418.GCOnw1n1-lkp@intel.com/
> 
> All warnings (new ones prefixed by >>):
> 
> >> drivers/tty/serial/8250/8250_ni.c:446:41: warning: 'nic7a69' defined but not used [-Wunused-const-variable=]
>      446 | static const struct ni16550_device_info nic7a69 = {
>          |                                         ^~~~~~~
> >> drivers/tty/serial/8250/8250_ni.c:439:41: warning: 'nic792b' defined but not used [-Wunused-const-variable=]
>      439 | static const struct ni16550_device_info nic792b = {
>          |                                         ^~~~~~~
> >> drivers/tty/serial/8250/8250_ni.c:433:41: warning: 'nic7772' defined but not used [-Wunused-const-variable=]
>      433 | static const struct ni16550_device_info nic7772 = {
>          |                                         ^~~~~~~
> >> drivers/tty/serial/8250/8250_ni.c:428:41: warning: 'nic7750' defined but not used [-Wunused-const-variable=]
>      428 | static const struct ni16550_device_info nic7750 = {
>          |                                         ^~~~~~~
> 
> 
> vim +/nic7a69 +446 drivers/tty/serial/8250/8250_ni.c
> 
>    426	
>    427	/* NI 16550 RS-485 Interface */
>  > 428	static const struct ni16550_device_info nic7750 = {
>    429		.uartclk = 33333333,
>    430	};
>    431	
>    432	/* NI CVS-145x RS-485 Interface */
>  > 433	static const struct ni16550_device_info nic7772 = {
>    434		.uartclk = 1843200,
>    435		.flags = NI_HAS_PMR,
>    436	};
>    437	
>    438	/* NI cRIO-904x RS-485 Interface */
>  > 439	static const struct ni16550_device_info nic792b = {
>    440		/* Sets UART clock rate to 22.222 MHz with 1.125 prescale */
>    441		.uartclk = 22222222,
>    442		.prescaler = 0x09,
>    443	};
>    444	
>    445	/* NI sbRIO 96x8 RS-232/485 Interfaces */
>  > 446	static const struct ni16550_device_info nic7a69 = {
>    447		/* Set UART clock rate to 29.629 MHz with 1.125 prescale */
>    448		.uartclk = 29629629,
>    449		.prescaler = 0x09,
>    450	};
>    451	

I'll go drop this patch, and the one before this in the series from you,
from my tree now, please fix it up and resend.

thanks,

greg k-h