From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6C72CDB465 for ; Thu, 19 Oct 2023 08:04:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232897AbjJSIEA (ORCPT ); Thu, 19 Oct 2023 04:04:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232870AbjJSIDu (ORCPT ); Thu, 19 Oct 2023 04:03:50 -0400 Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8173713D for ; Thu, 19 Oct 2023 01:03:47 -0700 (PDT) Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-32da9ef390fso3634790f8f.2 for ; Thu, 19 Oct 2023 01:03:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ventanamicro.com; s=google; t=1697702626; x=1698307426; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PH3CTrts87/bU27l3EN5JAWxWDeGWRQ9EMGON+8aZg4=; b=gMTUlmtnfk+4ygnaS28gWJ1F0cOGkdJsD8RqieWbofx8z9aUdiGQzf+y49rvw8eMji NYF3wqk4CdeEf/s9x3YcmFtOaemW8dzt1Nz3gy7AdOe8wyKLRJxykSUTiE0Q6TGwri1A tiZ1lG41ecgSPiahPtGdtQKRYeKpdxgz5gRJgQxSDqCSUOMo9F25sc6nkipivZ9GVrM9 Jf3kWzL15UsKfujybgFfFr5iKWxtaZOFO8TmT6qy0KdUp8592aMcZc9ZrklWqDbtGJez jirbapSwpADuM6J+IbCL431h+zPQwxnPcFEqDPaummcGWmeRslxa9i/Jk9YevTb34VMf 2Ahw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697702626; x=1698307426; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PH3CTrts87/bU27l3EN5JAWxWDeGWRQ9EMGON+8aZg4=; b=qqu1Bn6gOdvlV6pPdj3hN3Kjre52C6Q08G0MkoWJ6kH1Ygxo6WzLT+YjlikofE6E2H rldUGJXtntaIeUhuYEyvz4xns0CmcxGcXtIyF275HBzRHChn+ZsZ3W60IDeT91yqXjpo 5y7m2YhfOd6rYWgzq3xVu6+qt2Qdq8CO8adnYTEMatTo1jgrH1hQX1EpulYLysA8wc3m JbGzf5qGQTipe/d+w5NpeyBtAmUFVmCFlvBJCe1abdtzyraAbu4gsBc7J1FtOhODpYd1 s901VekQUeGmIJJJYHeh5NY0X3tPlJyJ4jzbE4jJ3Rf7Fl5wJQlj4RIFMZ0vjAfL6HNB JHng== X-Gm-Message-State: AOJu0Yy5vWXQhUOzUNK4+zF+jYddyhlafBFievSebSn8PwMR563J5TRk 0IjNv6JM6F5afr+mEOp1beATxQ== X-Google-Smtp-Source: AGHT+IHYgrLP95m19T8VV4j4IIENiIUl+y5B0n5FUWHPqZ/oM3kMO8SamCcDgZ0NeNrUiRnd8JBlpA== X-Received: by 2002:a05:6000:11c9:b0:31f:b120:143 with SMTP id i9-20020a05600011c900b0031fb1200143mr887639wrx.59.1697702625844; Thu, 19 Oct 2023 01:03:45 -0700 (PDT) Received: from localhost (cst2-173-16.cust.vodafone.cz. [31.30.173.16]) by smtp.gmail.com with ESMTPSA id c12-20020adfe70c000000b0031c6e1ea4c7sm3818471wrm.90.2023.10.19.01.03.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 01:03:45 -0700 (PDT) Date: Thu, 19 Oct 2023 10:03:44 +0200 From: Andrew Jones To: Anup Patel Cc: Paolo Bonzini , Atish Patra , Palmer Dabbelt , Paul Walmsley , Greg Kroah-Hartman , Jiri Slaby , Conor Dooley , kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-serial@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 5/8] RISC-V: Add inline version of sbi_console_putchar/getchar() functions Message-ID: <20231019-61b3653a98a1c021623b091e@orel> References: <20231012051509.738750-1-apatel@ventanamicro.com> <20231012051509.738750-6-apatel@ventanamicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231012051509.738750-6-apatel@ventanamicro.com> Precedence: bulk List-ID: X-Mailing-List: linux-serial@vger.kernel.org On Thu, Oct 12, 2023 at 10:45:06AM +0530, Anup Patel wrote: > The functions sbi_console_putchar() and sbi_console_getchar() are > not defined when CONFIG_RISCV_SBI_V01 is disabled so let us add > inline version of these functions to avoid "#ifdef" on user side. nit: Here and in the summary I'd probably use the word "stub" instead of "inline version". > > Signed-off-by: Anup Patel > --- > arch/riscv/include/asm/sbi.h | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/arch/riscv/include/asm/sbi.h b/arch/riscv/include/asm/sbi.h > index 12dfda6bb924..cbcefa344417 100644 > --- a/arch/riscv/include/asm/sbi.h > +++ b/arch/riscv/include/asm/sbi.h > @@ -271,8 +271,13 @@ struct sbiret sbi_ecall(int ext, int fid, unsigned long arg0, > unsigned long arg3, unsigned long arg4, > unsigned long arg5); > > +#ifdef CONFIG_RISCV_SBI_V01 > void sbi_console_putchar(int ch); > int sbi_console_getchar(void); > +#else > +static inline void sbi_console_putchar(int ch) { } > +static inline int sbi_console_getchar(void) { return -1; } > +#endif > long sbi_get_mvendorid(void); > long sbi_get_marchid(void); > long sbi_get_mimpid(void); > -- > 2.34.1 > Otherwise, Reviewed-by: Andrew Jones