Linux Serial subsystem development
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Florian Eckert <fe@dev.tdt.de>
Cc: Eckert.Florian@googlemail.com, jirislaby@kernel.org,
	pavel@ucw.cz, lee@kernel.org, kabel@kernel.org,
	u.kleine-koenig@pengutronix.de, ansuelsmth@gmail.com,
	m.brock@vanmierlo.com, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org, linux-leds@vger.kernel.org
Subject: Re: [PATCH v4 1/3] tty: whitespaces in descriptions corrected by replacing tabs with spaces
Date: Sun, 22 Oct 2023 13:19:58 +0200	[thread overview]
Message-ID: <2023102251-playoff-utensil-0457@gregkh> (raw)
In-Reply-To: <dce966de5bec159dae67d958653aaa42@dev.tdt.de>

On Sun, Oct 22, 2023 at 12:24:55PM +0200, Florian Eckert wrote:
> On 2023-10-21 18:28, Greg KH wrote:
> > On Thu, Oct 19, 2023 at 01:28:07PM +0200, Florian Eckert wrote:
> > > Tabs were used in the function description, to make this look more
> > > uniform, the tabs were replaced by spaces where necessary.
> > > 
> > > While we're at it, I also replaced the 'ndashes' with simple dashes,
> > > since
> > > only those are supported by sphinx.
> > > 
> > > Reviewed-by: Jiri Slaby <jirislaby@kernel.org>
> > > Signed-off-by: Florian Eckert <fe@dev.tdt.de>
> > > ---
> > >  drivers/tty/tty_io.c | 102
> > > +++++++++++++++++++++----------------------
> > >  1 file changed, 51 insertions(+), 51 deletions(-)
> > 
> > This didn't apply cleanly as portions of this patch were already in my
> > tree, what did tree did you make it against?
> 
> I have already seen that I should add a base commit next time.
> So I made it against the master from last week.
> 
> However, I was not sure which tree to use as I am changing
> something in the tty and led subsystem-
> 
> > Anyway, I've fixed it up and taken it now.
> 
> Thank you for adopting my change and correcting my commit so that
> it can be applied cleanly.
> 
> I will not add this patch in the next series, as it is already in the
> tty-testing branch [1] from you?

That is correct, thanks!

greg k-h

  reply	other threads:[~2023-10-22 11:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-19 11:28 [PATCH v4 0/3] ledtrig-tty: add additional tty state evaluation Florian Eckert
2023-10-19 11:28 ` [PATCH v4 1/3] tty: whitespaces in descriptions corrected by replacing tabs with spaces Florian Eckert
2023-10-21 16:08   ` Greg KH
2023-10-21 16:28   ` Greg KH
2023-10-22 10:24     ` Florian Eckert
2023-10-22 11:19       ` Greg KH [this message]
2023-10-19 11:28 ` [PATCH v4 2/3] tty: add new helper function tty_get_tiocm Florian Eckert
2023-10-21 16:15   ` Greg KH
2023-10-22 10:24     ` Florian Eckert
2023-10-19 11:28 ` [PATCH v4 3/3] leds: ledtrig-tty: add new line mode evaluation Florian Eckert
2023-10-21 16:07   ` Greg KH
2023-10-22 10:24     ` Florian Eckert
2023-10-22 11:24       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2023102251-playoff-utensil-0457@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Eckert.Florian@googlemail.com \
    --cc=ansuelsmth@gmail.com \
    --cc=fe@dev.tdt.de \
    --cc=jirislaby@kernel.org \
    --cc=kabel@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=m.brock@vanmierlo.com \
    --cc=pavel@ucw.cz \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox