From: Tony Lindgren <tony@atomide.com>
To: Johan Hovold <johan@kernel.org>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Dhruva Gole" <d-gole@ti.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
"Maximilian Luz" <luzmaximilian@gmail.com>
Subject: Re: [RFC PATCH 1/2] serial: core: Move tty and serdev to be children of serial core port device
Date: Tue, 24 Oct 2023 16:37:44 +0300 [thread overview]
Message-ID: <20231024133744.GN34982@atomide.com> (raw)
In-Reply-To: <ZTe9NdS160EU1RJJ@hovoldconsulting.com>
* Johan Hovold <johan@kernel.org> [231024 12:48]:
> Looks like this patch breaks the wakeup-irq hack in uart_suspend_port():
>
> tty_dev = device_find_child(uport->dev, &match, serial_match_port);
> if (tty_dev && device_may_wakeup(tty_dev)) {
> enable_irq_wake(uport->irq);
> put_device(tty_dev);
> mutex_unlock(&port->mutex);
> return 0;
> }
>
> There may be more of these hard-coded assumptions, this one I happened
> to be aware of.
OK thanks I'll take a look.
Regards,
Tony
prev parent reply other threads:[~2023-10-24 13:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 11:36 [RFC PATCH 1/2] serial: core: Move tty and serdev to be children of serial core port device Tony Lindgren
2023-10-24 11:36 ` [RFC PATCH 2/2] serial: core: Revert checks for tx runtime PM state Tony Lindgren
2023-10-24 11:52 ` [RFC PATCH 1/2] serial: core: Move tty and serdev to be children of serial core port device Greg Kroah-Hartman
2023-10-24 12:29 ` Tony Lindgren
2023-10-24 12:42 ` Andy Shevchenko
2023-10-24 12:45 ` Tony Lindgren
2023-10-24 14:01 ` Greg Kroah-Hartman
2023-10-25 6:51 ` Tony Lindgren
2023-10-25 7:33 ` Johan Hovold
2023-10-25 8:24 ` Tony Lindgren
2023-10-24 12:17 ` Andy Shevchenko
2023-10-24 12:43 ` Andy Shevchenko
2023-10-25 6:53 ` Tony Lindgren
2023-10-24 12:48 ` Johan Hovold
2023-10-24 13:37 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231024133744.GN34982@atomide.com \
--to=tony@atomide.com \
--cc=andriy.shevchenko@intel.com \
--cc=bigeasy@linutronix.de \
--cc=d-gole@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).