From: Tony Lindgren <tony@atomide.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Jiri Slaby" <jirislaby@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Andy Shevchenko" <andriy.shevchenko@intel.com>,
"Dhruva Gole" <d-gole@ti.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Johan Hovold" <johan@kernel.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
"Maximilian Luz" <luzmaximilian@gmail.com>
Subject: Re: [RFC PATCH 1/2] serial: core: Move tty and serdev to be children of serial core port device
Date: Wed, 25 Oct 2023 09:51:52 +0300 [thread overview]
Message-ID: <20231025065152.GO34982@atomide.com> (raw)
In-Reply-To: <2023102442-statue-kept-febc@gregkh>
* Greg Kroah-Hartman <gregkh@linuxfoundation.org> [231024 14:01]:
> On Tue, Oct 24, 2023 at 03:29:55PM +0300, Tony Lindgren wrote:
> > * Greg Kroah-Hartman <gregkh@linuxfoundation.org> [231024 11:52]:
> > > What does this change the sysfs tree to look like?
> >
> > On x86 qemu for the ttys:
> >
> > # find /sys -name tty
> > /sys/class/tty
> > /sys/class/tty/tty
> > /sys/devices/pnp0/00:04/00:04:0/00:04:0.0/tty
> > /sys/devices/platform/serial8250/serial8250:0/serial8250:0.3/tty
> > /sys/devices/platform/serial8250/serial8250:0/serial8250:0.1/tty
> > /sys/devices/platform/serial8250/serial8250:0/serial8250:0.2/tty
> > /sys/devices/virtual/tty
> > /sys/devices/virtual/tty/tty
>
> A diff of before vs. after would make more sense for those of us who
> don't have your same system configuration :)
Here's the diff of the same command before and after:
--- /tmp/before 2023-10-25 09:45:12.197283690 +0300
+++ /tmp/after 2023-10-25 09:43:30.681797899 +0300
@@ -1,7 +1,9 @@
# find /sys -name tty
/sys/class/tty
/sys/class/tty/tty
-/sys/devices/pnp0/00:04/tty
-/sys/devices/platform/serial8250/tty
+/sys/devices/pnp0/00:04/00:04:0/00:04:0.0/tty
+/sys/devices/platform/serial8250/serial8250:0/serial8250:0.3/tty
+/sys/devices/platform/serial8250/serial8250:0/serial8250:0.1/tty
+/sys/devices/platform/serial8250/serial8250:0/serial8250:0.2/tty
/sys/devices/virtual/tty
/sys/devices/virtual/tty/tty
There are multiple ports claimed by serial8250. So I think the new sysfs
output is correct showing more ttys. If there's some reason why serial8250
should only have one tty and this output is not correct let me know too..
Regards,
Tony
next prev parent reply other threads:[~2023-10-25 6:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 11:36 [RFC PATCH 1/2] serial: core: Move tty and serdev to be children of serial core port device Tony Lindgren
2023-10-24 11:36 ` [RFC PATCH 2/2] serial: core: Revert checks for tx runtime PM state Tony Lindgren
2023-10-24 11:52 ` [RFC PATCH 1/2] serial: core: Move tty and serdev to be children of serial core port device Greg Kroah-Hartman
2023-10-24 12:29 ` Tony Lindgren
2023-10-24 12:42 ` Andy Shevchenko
2023-10-24 12:45 ` Tony Lindgren
2023-10-24 14:01 ` Greg Kroah-Hartman
2023-10-25 6:51 ` Tony Lindgren [this message]
2023-10-25 7:33 ` Johan Hovold
2023-10-25 8:24 ` Tony Lindgren
2023-10-24 12:17 ` Andy Shevchenko
2023-10-24 12:43 ` Andy Shevchenko
2023-10-25 6:53 ` Tony Lindgren
2023-10-24 12:48 ` Johan Hovold
2023-10-24 13:37 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231025065152.GO34982@atomide.com \
--to=tony@atomide.com \
--cc=andriy.shevchenko@intel.com \
--cc=bigeasy@linutronix.de \
--cc=d-gole@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=luzmaximilian@gmail.com \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).