From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=atomide.com header.i=@atomide.com header.b="iluFk+PP" Received: from mail5.25mail.st (mail5.25mail.st [74.50.62.9]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E65F3BB; Tue, 21 Nov 2023 22:22:12 -0800 (PST) Received: from localhost (91-158-86-216.elisa-laajakaista.fi [91.158.86.216]) by mail5.25mail.st (Postfix) with ESMTPSA id 530B060852; Wed, 22 Nov 2023 06:21:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=atomide.com; s=25mailst; t=1700634132; bh=IzPNJc1JTuqWO45Rxq17COGNEUpGUDxnGho6xDUJ+xg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=iluFk+PPWWXytS2xsj6IFeEAF0d3poODgAFNhyUdnh5cBXFUZJeQs6F98rCPaKd/t 1DZc8N13h9WuIsLgza/COJTwTaAOqT5Z/6kc1+vqy9mQylJs2W78sfWfVMwMUVXgrU x7oQvxK5zbGZaVNIHDZ2jMBNZqPelr0JzaLq+4YA3JrQLUgqQ/70hMnA0M2VjpB9X2 qAVNwBgxYH8Y7qMNG1IEblbe84+mDPprjjeZzDb3soZr1invzcyaSV2sXnKfBUbNBo fQ6Sbc12ghN2wzpd+jrozrvxdrDoaTV/kuBoZzprC5hKoMKAPPrMbarZe4dTZTtuxr LnBaY/S83yLOw== Date: Wed, 22 Nov 2023 08:21:38 +0200 From: Tony Lindgren To: Andy Shevchenko Cc: Greg Kroah-Hartman , Jiri Slaby , Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , "David S . Miller" , Dhruva Gole , Ilpo =?utf-8?B?SsOkcnZpbmVu?= , Johan Hovold , Sebastian Andrzej Siewior , Vignesh Raghavendra , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org Subject: Re: [PATCH v3 1/3] printk: Save console options for add_preferred_console_match() Message-ID: <20231122062138.GD5169@atomide.com> References: <20231121113203.61341-1-tony@atomide.com> <20231121113203.61341-2-tony@atomide.com> <20231122061800.GC5169@atomide.com> Precedence: bulk X-Mailing-List: linux-serial@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231122061800.GC5169@atomide.com> * Tony Lindgren [231122 08:18]: > * Andy Shevchenko [231121 17:53]: > > On Tue, Nov 21, 2023 at 01:31:55PM +0200, Tony Lindgren wrote: > > > +int __init console_opt_save(char *str) > > > > str is not const? Hmm... > > Nice yes it can be const char *str here. Hmm maybe with the third patch > also console_setup() can use const char * now.. Will check. Nah console_setup() uses __setup(). Tony