From: Greg KH <gregkh@linuxfoundation.org>
To: Christina Quast <contact@christina-quast.de>
Cc: linux-serial@vger.kernel.org,
"Daniel Beer" <daniel.beer@igorinstitute.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: Re: [PATCH v3 RESEND] hid-ft260: Add serial driver
Date: Tue, 28 Nov 2023 10:29:46 +0000 [thread overview]
Message-ID: <2023112831-pacifist-lure-428a@gregkh> (raw)
In-Reply-To: <0fb134f7-f72e-4742-9c2d-c68f83b67975@christina-quast.de>
On Sun, Nov 26, 2023 at 10:53:18AM +0100, Christina Quast wrote:
> Hi Greg!
>
> Thanks for the comments!
>
> On 11/22/23 11:15, Greg KH wrote:
> > On Wed, Nov 22, 2023 at 10:40:03AM +0100, Christina Quast wrote:
> > > This commit adds a serial interface /dev/FTx which implements the tty
> > > serial driver ops, so that it is possible to set the baudrate, send
> > > and receive data, etc.
> > Why is this a serial device? What type of device is it?
> >
> > And why "FTx"? Where did that name come from? That's not a "normal"
> > tty name.
> I meant /dev/ttyFTx. Since it's a hid device providing a serial interface,
> in theory you could also call it /dev/ttySx or /dev/ttyUSBx, but both feel
> wrong. It's an FTDI device, that functions as a USB to UART / I2C Master. Do
> you have a better name in mind?
I thought we had a HID tty device name already, perhaps dig around for
that and tie into that interface? If not, sure, youcan use ttyFTx, but
it needs to be documented somewhere (and the correct wording here in the
changelog as well.)
thanks,
greg k-h
next prev parent reply other threads:[~2023-11-28 10:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 9:40 [PATCH v3 RESEND] hid-ft260: Add serial driver Christina Quast
2023-11-22 10:15 ` Greg KH
2023-11-26 9:53 ` Christina Quast
2023-11-28 10:13 ` Ilpo Järvinen
2023-11-30 13:38 ` Christina Quast
2023-11-28 10:29 ` Greg KH [this message]
2023-11-30 13:55 ` Christina Quast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023112831-pacifist-lure-428a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=contact@christina-quast.de \
--cc=daniel.beer@igorinstitute.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox