From: Greg KH <gregkh@linuxfoundation.org>
To: Christina Quast <contact@christina-quast.de>
Cc: linux-serial@vger.kernel.org, ilpo.jarvinen@linux.intel.com,
johan@kernel.org, daniel.beer@igorinstitute.com
Subject: Re: [PATCH v4] hid-ft260: Add serial driver
Date: Thu, 7 Dec 2023 10:40:45 +0900 [thread overview]
Message-ID: <2023120734-ravioli-unclasp-e8df@gregkh> (raw)
In-Reply-To: <20231204184542.16835-1-contact@christina-quast.de>
On Mon, Dec 04, 2023 at 07:45:42PM +0100, Christina Quast wrote:
> Adds the serial driver for FT260 USB HID devices, providing direct and
> simplified access to UART functionality without the need for FT260 HID
> report format knowledge.
>
> This chip implements an UART and I2C interface, but only the latter was
> previously supported with a kernel driver. For the UART interface, only
> FTDI example code using hidraw from userspace was available.
>
> This commit adds a serial interface /dev/ttyFTx (FT as in FT260), which
> implements tty serial driver ops, facilitating baudrate configuration,
> data transmission and reception, termios settings.
>
> Signed-off-by: Daniel Beer <daniel.beer@igorinstitute.com>
> Signed-off-by: Christina Quast <contact@christina-quast.de>
> ---
>
> V1 -> V2: Adressed review comments, added power saving mode quirk
> V2 -> V3: Added return 0 in ft260_i2c_probe function
> V3 -> V4:
> - Adressed review comments
> - Added get_icount
> - Fixed tty port lifetime bug
Reviewed-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
prev parent reply other threads:[~2023-12-07 6:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 18:45 [PATCH v4] hid-ft260: Add serial driver Christina Quast
2023-12-07 1:40 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023120734-ravioli-unclasp-e8df@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=contact@christina-quast.de \
--cc=daniel.beer@igorinstitute.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=johan@kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox